[TG Mirror] Makes Gondolapods great again [MDB IGNORE] #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ffmirrorbot[bot]](https://avatars.githubusercontent.com/in/391347?s=60&v=4){kind=small}
* Makes Gondolapods great again (#78900) ## About The Pull Request Fixes #73310 Bug fix for gondola supplypods generated with the Config/Launch Supplypod admin verb. open_pod() now dumps the contents of the holder reference it was passed (holder = src supplypod in all cases except for the gondola pod) allowing gondola pods to actually deliver their cargo. Mobs in the new gondola pod get their perspective reset instead of being stuck in the void of nullspace until the pod opens. The mob's plane is set on the pod opening to allow items to appear on top of the pod, and reset to standard mob plane on closing. In the case of a reversing pod, contents are properly stored in the supplypod and the outgoing mob is qdel'd (new one is spawned when the pod lands, holder != src should only be true in the case of the gondola pod). Fixed a runtime where glow_effect.plane was being modified while glow_effect is null. Removes incorrect comment. Everything tested locally. ## Why It's Good For The Game Makes the gondola supplypod variant actually functional. ## Changelog :cl: admin: Gondola supplypods are functional again. /:cl: * Makes Gondolapods great again --------- Co-authored-by: Isratosh <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jan 24, 2024
…30 (#42) * Organ movement refactor *Un-nullspaces your organs* * Fix conflicts I checked the conflicts on the two weird conflicts and no previous TG pr touches them i assume its just github being github because those shoulden't be conflicts *shrug * Fix #1 uhh...this is going to be a long one * Fix #2 Modular Movement Flags * Fix #3 It builds now * Fix #4 Oh god it builds now, I missed some things * Fix #5 No more Runtimesplosion Now time for Synths * Fix #6 Shut up CI Where did you even come from * Fix #7 Didn't I fix you already? * Update language.dm * Fix Opfor jank * Revert "Fix Opfor jank" This reverts commit 6af2fd71d85e6be58890f27f4f32bf92cfcb00fb. * Revert "Revert "Fix Opfor jank"" This reverts commit cbd72277afd05f30a0b6f499a8162412fe3663ea. * Update module_template.md * Revert "Revert "Revert "Fix Opfor jank""" This reverts commit 71ae4c10d8e9876c97f67278c55caa994b26a7dc. * Fixing a runtime with H.A.R.S. (#80772) The brain gets moved into the chest with H.A.R.S. now, but the bodypart insertion and removal procs for it still asume it can only be found in the head. This should fix it. For the sake of preventing similar issues in the future, I've also updated the pretty-much-identical versions for ears, eyes and tongue. I've checked, and the brain var is only used by the head for visuals and examine strings. * Modular updates * Fix synths not dying after being debrained * Update brain.dm * Update cortical_borer.dm * Revert "Fixing a runtime with H.A.R.S. (#80772)" This reverts commit 225035c2101d0e8946f7ef8cb375b68f2d25533a. * Update dismemberment.dm --------- Co-authored-by: Time-Green <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Ghom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: ${this.url}
Original PR: (original url)
About The Pull Request
Fixes #73310
Bug fix for gondola supplypods generated with the Config/Launch Supplypod admin verb. open_pod() now dumps the contents of the holder reference it was passed (holder = src supplypod in all cases except for the gondola pod) allowing gondola pods to actually deliver their cargo. Mobs in the new gondola pod get their perspective reset instead of being stuck in the void of nullspace until the pod opens. The mob's plane is set on the pod opening to allow items to appear on top of the pod, and reset to standard mob plane on closing.
In the case of a reversing pod, contents are properly stored in the supplypod and the outgoing mob is qdel'd (new one is spawned when the pod lands, holder != src should only be true in the case of the gondola pod).
Fixed a runtime where glow_effect.plane was being modified while glow_effect is null. Removes incorrect comment.
Everything tested locally.
Why It's Good For The Game
Makes the gondola supplypod variant actually functional.
Changelog
🆑 Isratosh
admin: Gondola supplypods are functional again.
/:cl: