Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skyrat Mirror] [MODULAR] Fixes an oversight with paper masks + adds action button #68

Closed
wants to merge 1 commit into from

Conversation

ffmirrorbot[bot]
Copy link

@ffmirrorbot ffmirrorbot bot commented Oct 15, 2023

Original PR: ${this.url}

About The Pull Request

Fixes (original url)

Fixes an issue that would cause the layering to get messed up. Adds an action button as well, and right alt click + contextual tooltip for adjusting the hair. Got rid of the verb. You can also now hide the strap if you want via ctrl+ click.

Also, it was the original PR author's intent to have the mask start off as being over the hair so now that happens.

Finally you now need to use a pen to change the drawing on the mask. No more magic paper.

How This Contributes To The Skyrat Roleplay Experience

QoL update and bugfix.

Proof of Testing

Action button + context

dreamseeker_4LpNlDkmaZ

image

Works

dreamseeker_fRPL5GRlPv

Messages are different depending on if you are currently wearing it or not.

dreamseeker_0AJEwV5n13

Changelog

🆑 vinylspiders
fix: fixed an issue that could cause the hair the layering option to reset itself upon unequipping a paper mask
qol: paper masks have an action button for adjusting the mask drawing + hair layering, as well as the ability to hide the strap with ctrl click. changing the drawings on the mask now require a pen.
/:cl:

…24326)

* Fixes an oversight with paper masks + adds action button

* Makes action button have a right click and a left click

* Adds ability to hide strap

* Hideable strap + cleaning up the crap
@Iajret Iajret closed this Oct 17, 2023
@Iajret Iajret deleted the upstream-mirror-24326 branch October 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants