Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TG Mirror] Laser Carbine sprite and sound improvement [MDB IGNORE] #34

Closed
wants to merge 1 commit into from

Conversation

ffmirrorbot[bot]
Copy link

@ffmirrorbot ffmirrorbot bot commented Oct 13, 2023

Mirrored on Skyrat: ${this.url}
Original PR: (original url)

About The Pull Request

Changes the laser carbine sprite and makes the orange laser sprite brighter (the laser carbine shot orange lasers from the start). Changes the laser2.ogg to a new sound that is now used by the laser carbine (can be heard in the video):

Laser.Carbine.new.sounds.mp4

NEW SPRITE:
laser carbine big

OLD SPRITE:
old carbine

Why It's Good For The Game

The laser carbine sprite must be improved, as in the original PR people wanted it to be "polished" so I did it. Polished the sprite without changing the core design.
image

New sounds give it a unique sound to distinguish it from other guns, it's also less noise-polluting than normal laser gun sound which is long and too beefy for a 10-burn damage gun.

Changelog

🆑 DrDiasyl
sound: laser2.ogg sound has been changed. Now laser carbine uses it.
image: Laser carbine and orange laser sprite have been improved.
/:cl:

…305)

* Laser Carbine sprite and sound improvement (#78831)

## About The Pull Request
Changes the laser carbine sprite and makes the orange laser sprite
brighter (the laser carbine shot orange lasers from the start). Changes
the laser2.ogg to a new sound that is now used by the laser carbine (can
be heard in the video):

https://github.com/tgstation/tgstation/assets/42353186/cfaff327-335f-4e6b-9773-b1ce62600212

**NEW SPRITE:**
![laser carbine
big](https://github.com/tgstation/tgstation/assets/42353186/5e0b1c90-527c-47ae-9747-7f833a84c880)

**OLD SPRITE:**
![old
carbine](https://github.com/tgstation/tgstation/assets/42353186/5d2eb35c-9ddb-49db-99b3-e1631a1db8dd)
## Why It's Good For The Game
The laser carbine sprite must be improved, as in the original PR people
wanted it to be "polished" so I did it. Polished the sprite without
changing the core design.

![image](https://github.com/tgstation/tgstation/assets/42353186/0c6f73a3-0dd0-4ba5-9cf8-dd34cade2fd1)

New sounds give it a unique sound to distinguish it from other guns,
it's also less noise-polluting than normal laser gun sound which is long
and too beefy for a 10-burn damage gun.
## Changelog
:cl:
sound: laser2.ogg sound has been changed. Now laser carbine uses it.
image: Laser carbine and orange laser sprite have been improved.
/:cl:

* Laser Carbine sprite and sound improvement

---------

Co-authored-by: DrTuxedo <[email protected]>
@Iajret Iajret closed this Oct 17, 2023
@Iajret Iajret deleted the upstream-mirror-24305 branch October 17, 2023 10:22
Iajret pushed a commit that referenced this pull request Jan 24, 2024
* [MIRROR] FOV is Dead (Long Live FOV) [MDB IGNORE] (#25600)

* FOV is Dead (Long Live FOV)

* Update _megafauna.dm

* Update _vehicle.dm

* FOV Hotfix: Actually offsets gameplane render relays

* removes redundant visual_shadow

* removes GAME_PLANE_UPPER references

* Update mob_movement.dm

---------

Co-authored-by: LemonInTheDark <[email protected]>
Co-authored-by: Bloop <[email protected]>
Co-authored-by: Gandalf <[email protected]>

* Disables the FOV visual cue

* Revert "Disables the FOV visual cue"

This reverts commit 6f5785c79e8c5a376da7f347a25bed2a4bb19d29.

* Just disables the mask fov

* Update wind_turbine.dm

---------

Co-authored-by: SkyratBot <[email protected]>
Co-authored-by: LemonInTheDark <[email protected]>
Co-authored-by: Gandalf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants