Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partitionedge and partitionedges to accept pairs #47

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

JoeyT1994
Copy link
Contributor

A quick PR which allows partitionedge(pg, edge) and partitionedges(pg, edges) to accept a Pair or Vector{Pair} alongside AbstractEdge and Vector{AbstractEdge} types.

@mtfishman
Copy link
Member

Thanks, could you add some tests?

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (569e829) 78.54% compared to head (cb69407) 78.41%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Graphs/partitionedgraphs/partitionedgraph.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   78.54%   78.41%   -0.14%     
==========================================
  Files          31       31              
  Lines        1184     1186       +2     
==========================================
  Hits          930      930              
- Misses        254      256       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeyT1994
Copy link
Contributor Author

Sure I added a few tests.

@mtfishman
Copy link
Member

Looks good, thanks!

@mtfishman mtfishman merged commit 29a5bee into ITensor:main Jan 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants