Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Expose /licensed-items endpoint in api server #6958

Merged
merged 63 commits into from
Dec 13, 2024
Merged

✨ Expose /licensed-items endpoint in api server #6958

merged 63 commits into from
Dec 13, 2024

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Dec 12, 2024 •
edited
Loading

What do these changes do?

  • Introduce RabbitMqRpcClient in api server
  • Connect it to the webserver
  • Expose GET /v0/licensed-items

Related issue/s

How to test

cd services/api-server; make install-dev;
cd tests/unit
python -m pytest -k test_get_licensed_items

Dev-ops checklist

matusdrobuliak66 and others added 30 commits December 9, 2024 16:42
@matusdrobuliak66
db layer licensed items purchase
829eae9
@matusdrobuliak66
rut part
a975a63
@matusdrobuliak66
merge master
fc62c0d
@matusdrobuliak66
renaming tests
78ef2cc
@matusdrobuliak66
rpc interface
a6f49cd
@matusdrobuliak66
RUT unit tests
f5de79b
@matusdrobuliak66
RUT unit tests
acd4c88
@matusdrobuliak66
RUT unit tests
317cf1d
@matusdrobuliak66
webserver part
932fb00
@matusdrobuliak66
webserver part
06f5743
@matusdrobuliak66
open api specs
dbd1ffe
@matusdrobuliak66
webserver part tests
6bec5ff
@matusdrobuliak66
Merge branch 'master' into introduce-vip-models-pricing-4-part
754cd58
@matusdrobuliak66
open api specs
3755dce
@matusdrobuliak66
Merge branch 'introduce-vip-models-pricing-4-part' of github.com:matu…
8f264b1 
…sdrobuliak66/osparc-simcore into introduce-vip-models-pricing-4-part
@matusdrobuliak66
fix type
4185852
@matusdrobuliak66
fix type
4c31cd0
@matusdrobuliak66
fix type
530fda0
@matusdrobuliak66
fix type
00d40bd
@matusdrobuliak66
Merge branch 'master' into introduce-vip-models-pricing-4-part
fa3c648
@matusdrobuliak66
Merge branch 'master' into introduce-vip-models-pricing-4-part
12ebf32
@matusdrobuliak66
review @pcrespov
969f982
@matusdrobuliak66
adding purchase item functionality
138412e
@matusdrobuliak66
open api specs
7e9de14
@matusdrobuliak66
improve error handling
4f1c5d6
@matusdrobuliak66
open api specs
26f9c57
@matusdrobuliak66
fix import
583b2b4
@matusdrobuliak66
fix import
4a1008f
@matusdrobuliak66
fix typecheck
776806b
@matusdrobuliak66
fix typecheck
fadfa1f
pcrespov
pcrespov approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Great work!
I would also like to follow up on some conventions with you before we add more functionality to the api-server :-)

services/api-server/src/simcore_service_api_server/api/routes/licensed_items.py Outdated Show resolved Hide resolved
services/api-server/src/simcore_service_api_server/services_rpc/wb_api_server.py Outdated Show resolved Hide resolved
services/api-server/tests/unit/test_licensed_items.py Show resolved Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/model_adapter.py Outdated Show resolved Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/model_adapter.py Outdated Show resolved Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/model_adapter.py Show resolved Hide resolved
services/api-server/src/simcore_service_api_server/services_rpc/wb_api_server.py Outdated Show resolved Hide resolved
sanderegg
sanderegg approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) December 12, 2024 14:13
matusdrobuliak66
matusdrobuliak66 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@bisgaard-itis bisgaard-itis changed the title ✨ Expose /licensed-items/page endpoint in api server ✨ Expose /licensed-items endpoint in api server Dec 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) December 13, 2024 09:00
@bisgaard-itis bisgaard-itis merged commit e97f83b into ITISFoundation:master Dec 13, 2024
93 checks passed
@bisgaard-itis bisgaard-itis deleted the 6948-expose-licensing-endpoints-api-server branch December 13, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@bisgaard-itis bisgaard-itis

Labels
a:apiserver api-server service
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
5 participants
@bisgaard-itis @giancarloromeo @pcrespov @sanderegg @matusdrobuliak66