Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Clean deprecated (Pydantic v2) #6955

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 12, 2024

What do these changes do?

Clean deprecated code introduced after migration to Pydantic v2.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Dec 12, 2024
@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Dec 12, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (e6fc642) to head (ca1adf8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6955      +/-   ##
==========================================
- Coverage   88.09%   85.36%   -2.74%     
==========================================
  Files        1589      632     -957     
  Lines       62243    30616   -31627     
  Branches     2012      262    -1750     
==========================================
- Hits        54831    26134   -28697     
+ Misses       7076     4422    -2654     
+ Partials      336       60     -276     
Flag Coverage Δ
integrationtests 65.01% <ø> (+0.02%) ⬆️
unittests 86.30% <ø> (-0.02%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.86% <ø> (-12.54%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.75% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fc642...ca1adf8. Read the comment docs.

@giancarloromeo giancarloromeo marked this pull request as ready for review December 12, 2024 10:53
Copy link

sonarcloud bot commented Dec 12, 2024

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@giancarloromeo giancarloromeo enabled auto-merge (squash) December 12, 2024 11:08
@giancarloromeo giancarloromeo merged commit 065bd8f into ITISFoundation:master Dec 12, 2024
101 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants