🐛Autoscaling: Fixes return value of Docker node activation

[sanderegg]

What do these changes do?

• ✨Autoscaling: scale down while in use 🚨 #6898 brought an issue that this PR hopefully fixes
• the Docker Node tagging operation was not properly returning the updated Node object, therefore the node would be activated and instantly de-activated, which prevents any service from starting

Related issue/s

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.98%. Comparing base (08981e0) to head (756d29c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (08981e0) and HEAD (756d29c). Click for more details.

HEAD has 29 uploads less than BASE

Flag	BASE (08981e0)	HEAD (756d29c)
unittests	30	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #6953       +/-   ##
===========================================
- Coverage   88.08%   66.98%   -21.10%     
===========================================
  Files        1589      669      -920     
  Lines       62242    32759    -29483     
  Branches     2012      262     -1750     
===========================================
- Hits        54823    21943    -32880     
- Misses       7083    10756     +3673     
+ Partials      336       60      -276     

Flag	Coverage Δ
integrationtests	64.99% <ø> (-3.09%)	⬇️
unittests	95.42% <85.71%> (+9.13%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.37% <ø> (-8.02%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	95.42% <85.71%> (+<0.01%)	⬆️
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	78.86% <ø> (-12.48%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	59.86% <ø> (-29.89%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	59.57% <ø> (-28.17%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08981e0...756d29c. Read the comment docs.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud