Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Serialize Colors as HEX #6839

Merged

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 26, 2024

What do these changes do?

Colors are now always serialized in HEX format:

Example:

"#b7e28d" => "#b7e28d"
"Cyan" =>  "#0ff"

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 26, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 26, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 26, 2024 10:56
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (afd66d4) to head (c32b848).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6839      +/-   ##
==========================================
+ Coverage   88.40%   89.50%   +1.10%     
==========================================
  Files        1550     1252     -298     
  Lines       61749    53015    -8734     
  Branches     2164      940    -1224     
==========================================
- Hits        54588    47452    -7136     
+ Misses       6832     5428    -1404     
+ Partials      329      135     -194     
Flag Coverage Δ
integrationtests 72.50% <ø> (+2.42%) ⬆️
unittests 87.20% <100.00%> (+0.19%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.16% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.49% <ø> (+0.08%) ⬆️
director_v2 91.13% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.68% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afd66d4...c32b848. Read the comment docs.

Copy link

sonarcloud bot commented Nov 26, 2024

@giancarloromeo giancarloromeo merged commit dc0c37d into ITISFoundation:master Nov 26, 2024
89 of 90 checks passed
@giancarloromeo giancarloromeo deleted the serialize-colors-as-hex branch November 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants