-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes OrderBy serialization error in pydanticv2 #6828
🐛 Fixes OrderBy serialization error in pydanticv2 #6828
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6828 +/- ##
==========================================
- Coverage 88.40% 88.34% -0.06%
==========================================
Files 1550 1383 -167
Lines 61750 57970 -3780
Branches 2164 1661 -503
==========================================
- Hits 54589 51215 -3374
+ Misses 6832 6492 -340
+ Partials 329 263 -66
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (its getting pretty long :D )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Quality Gate passedIssues Measures |
What do these changes do?
Fixes
AttributeError: Can't pickle local object 'create_ordering_query_model_classes.<locals>._OrderBy'
introduce by the update to pydantic 2 of
OrderBy
-like factory model.Related issue/s
How to test
Dev-ops
None