Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed issue with serialisation of docker specs #6819

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 25, 2024

What do these changes do?

The AioDockerServiceSpec.model_dump would serialise without using all the require parameters. This was not corrected.
This was causing the autoscaling not to work since the information from the specs was not merged.

Bonus: Fixed flaky test behaviour with state_exclude

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (74c3690) to head (a3e5bda).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6819      +/-   ##
==========================================
+ Coverage   88.39%   89.48%   +1.09%     
==========================================
  Files        1550     1252     -298     
  Lines       61750    53015    -8735     
  Branches     2164      940    -1224     
==========================================
- Hits        54584    47443    -7141     
+ Misses       6837     5437    -1400     
+ Partials      329      135     -194     
Flag Coverage Δ
integrationtests 64.76% <100.00%> (-0.01%) ⬇️
unittests 87.05% <75.00%> (+0.63%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.16% <100.00%> (-0.01%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.02% <100.00%> (-0.11%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.68% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c3690...a3e5bda. Read the comment docs.

---- 🚨 Try these New Features:

@GitHK GitHK self-assigned this Nov 25, 2024
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Nov 25, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 25, 2024
@GitHK GitHK marked this pull request as ready for review November 25, 2024 09:18
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@GitHK GitHK enabled auto-merge (squash) November 25, 2024 12:38
Copy link

sonarcloud bot commented Nov 25, 2024

@GitHK GitHK merged commit a703f56 into ITISFoundation:master Nov 25, 2024
86 of 90 checks passed
@GitHK GitHK deleted the pr-osparc-fix-issue-with-constraints branch November 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants