-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixed issue with serialisation of docker specs #6819
🐛 Fixed issue with serialisation of docker specs #6819
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6819 +/- ##
==========================================
+ Coverage 88.39% 89.48% +1.09%
==========================================
Files 1550 1252 -298
Lines 61750 53015 -8735
Branches 2164 940 -1224
==========================================
- Hits 54584 47443 -7141
+ Misses 6837 5437 -1400
+ Partials 329 135 -194
Continue to review full report in Codecov by Sentry.
|
services/director-v2/tests/unit/with_dbs/test_modules_dynamic_sidecar_docker_service_specs.py
Outdated
Show resolved
Hide resolved
services/director-v2/tests/unit/with_dbs/test_modules_dynamic_sidecar_docker_service_specs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks!
...imcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_event_create_sidecars.py
Outdated
Show resolved
Hide resolved
…ue-with-constraints
Quality Gate passedIssues Measures |
What do these changes do?
The
AioDockerServiceSpec.model_dump
would serialise without using all the require parameters. This was not corrected.This was causing the autoscaling not to work since the information from the specs was not merged.
Bonus: Fixed flaky test behaviour with
state_exclude
Related issue/s
How to test
Dev-ops checklist