Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Director-v0: added background task that pre-builds the registry cache #6814

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 22, 2024

What do these changes do?

This PR re-creates the background task that updates the cache of the services

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:director issue related with the director service t:maintenance Some planned maintenance work labels Nov 22, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 22, 2024
@sanderegg sanderegg self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.19%. Comparing base (9df9be7) to head (af754e6).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9df9be7) and HEAD (af754e6). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (9df9be7) HEAD (af754e6)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6814       +/-   ##
===========================================
- Coverage   88.33%   65.19%   -23.15%     
===========================================
  Files        1532      637      -895     
  Lines       60983    32094    -28889     
  Branches     2013      318     -1695     
===========================================
- Hits        53872    20923    -32949     
- Misses       6795    11111     +4316     
+ Partials      316       60      -256     
Flag Coverage Δ *Carryforward flag
integrationtests 64.76% <ø> (ø) Carriedforward from 9df9be7
unittests 76.40% <91.66%> (-9.84%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 76.40% <91.66%> (-0.01%) ⬇️
director_v2 76.54% <ø> (-14.60%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.86%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.56% <ø> (-29.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df9be7...af754e6. Read the comment docs.

---- 🚨 Try these New Features:

@sanderegg sanderegg requested a review from odeimaiz November 22, 2024 15:09
@sanderegg sanderegg force-pushed the dv-0/pre-build-and-update-cache branch from 8dc7cda to 3ed57ec Compare November 22, 2024 15:13
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg force-pushed the dv-0/pre-build-and-update-cache branch from 3ed57ec to 7f77193 Compare November 25, 2024 08:57
@sanderegg sanderegg enabled auto-merge (squash) November 25, 2024 08:57
@sanderegg sanderegg force-pushed the dv-0/pre-build-and-update-cache branch from 4ad8367 to af754e6 Compare November 25, 2024 09:46
Copy link

sonarcloud bot commented Nov 25, 2024

@sanderegg sanderegg merged commit 0aeae77 into ITISFoundation:master Nov 25, 2024
83 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director issue related with the director service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants