Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [e2e] _open_with_resources #6809

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 22, 2024

What do these changes do?

Make e2e-playwright wait for the study title to be filled in the Study Options (one of the current issues in master)

NewMember

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 22, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 22, 2024
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Nov 22, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 22, 2024 12:24
@odeimaiz odeimaiz enabled auto-merge (squash) November 22, 2024 12:25
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (28a54d6) to head (cd61964).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6809      +/-   ##
==========================================
+ Coverage   88.38%   88.42%   +0.04%     
==========================================
  Files        1545     1545              
  Lines       61619    61596      -23     
  Branches     2164     2157       -7     
==========================================
+ Hits        54460    54465       +5     
+ Misses       6830     6802      -28     
  Partials      329      329              
Flag Coverage Δ *Carryforward flag
integrationtests 64.77% <ø> (-0.02%) ⬇️
unittests 86.34% <ø> (+0.05%) ⬆️ Carriedforward from ca228c3

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 78.42% <ø> (ø)
pkg_aws_library 93.28% <ø> (ø)
pkg_dask_task_models_library 96.57% <ø> (ø)
pkg_models_library 91.21% <ø> (+0.07%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.31% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.31% <ø> (+0.21%) ⬆️
pkg_settings_library 90.62% <ø> (ø)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.50% <ø> (+0.08%) ⬆️
director_v2 91.13% <ø> (+0.11%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.72% <ø> (-0.04%) ⬇️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (+0.14%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.69% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a54d6...cd61964. Read the comment docs.

---- 🚨 Try these New Features:

tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
@odeimaiz odeimaiz changed the title 🐛 [e2e] open_with_resources 🐛 [e2e] _open_with_resources Nov 22, 2024
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
tests/e2e-playwright/tests/conftest.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 22, 2024

@odeimaiz odeimaiz merged commit 1eb6dd0 into ITISFoundation:master Nov 22, 2024
87 of 90 checks passed
@odeimaiz odeimaiz deleted the e2e/wait_for_title branch November 23, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants