Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix OpenTelemetry endpoint URL creation #6802

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 22, 2024

What do these changes do?

The migration to Pydantic v2 caused issues when building the endpoint to the OpenTelemetry service.

raise ConnectionError(e, request=request)\nrequests.exceptions.ConnectionError: HTTPConnectionPool(host='otel-collector', port=80): Max retries exceeded with url: /:4318/v1/traces (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7ea65c17d510>: Failed to establish a new connection: [Errno 111] Connection refused'))

As you can see from logs, it tried to connect to /:4318/v1/traces, which contains a / derived from new Pydantic v2 AnyUrl type.

YARL will be used for URL composition.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (3655208) to head (8b55a66).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
+ Coverage   87.81%   88.40%   +0.59%     
==========================================
  Files        1508     1201     -307     
  Lines       59494    53461    -6033     
  Branches     2157     1032    -1125     
==========================================
- Hits        52243    47263    -4980     
+ Misses       6922     6011     -911     
+ Partials      329      187     -142     
Flag Coverage Δ
integrationtests 64.78% <ø> (+11.31%) ⬆️
unittests 85.76% <100.00%> (-0.24%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.39% <100.00%> (+0.09%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.41% <ø> (ø)
director_v2 89.67% <ø> (-1.37%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.64% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.71% <ø> (+1.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3655208...8b55a66. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo changed the title Fix OpenTelemetry endpoint URL Fix OpenTelemetry endpoint URL creation Nov 22, 2024
@giancarloromeo giancarloromeo changed the title Fix OpenTelemetry endpoint URL creation 🐛 Fix OpenTelemetry endpoint URL creation Nov 22, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 22, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 22, 2024 10:42
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some minor notes

@giancarloromeo giancarloromeo enabled auto-merge (squash) November 22, 2024 11:15
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@giancarloromeo giancarloromeo merged commit f28db63 into ITISFoundation:master Nov 22, 2024
89 of 90 checks passed
@giancarloromeo giancarloromeo deleted the fix-opentelemetry-endpoint-url branch November 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants