-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix OpenTelemetry endpoint URL creation #6802
🐛 Fix OpenTelemetry endpoint URL creation #6802
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6802 +/- ##
==========================================
+ Coverage 87.81% 88.40% +0.59%
==========================================
Files 1508 1201 -307
Lines 59494 53461 -6033
Branches 2157 1032 -1125
==========================================
- Hits 52243 47263 -4980
+ Misses 6922 6011 -911
+ Partials 329 187 -142
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, some minor notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Quality Gate passedIssues Measures |
What do these changes do?
The migration to Pydantic v2 caused issues when building the endpoint to the OpenTelemetry service.
As you can see from logs, it tried to connect to
/:4318/v1/traces
, which contains a / derived from new Pydantic v2AnyUrl
type.YARL will be used for URL composition.
Related issue/s
How to test
Dev-ops checklist