Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Sort folders alphabetically #6794

Merged
merged 5 commits into from
Nov 21, 2024
Merged

🎨 [Frontend] Sort folders alphabetically #6794

merged 5 commits into from
Nov 21, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 21, 2024 •
edited
Loading

What do these changes do?

Merry xmas @wvangeit!

SortedFolders

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 21, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 21, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 21, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 21, 2024 14:29
@wvangeit
Copy link
Contributor

Thx 🎄 ⛄ 🎄 ⛄ 🎄 ⛄

matusdrobuliak66
matusdrobuliak66 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: I would assume, as a user, that the default sorting should be by "last modified"?

@odeimaiz
Copy link
Member Author

Q: I would assume, as a user, that the default sorting should be by "last modified"?

In the tree(s) alphabetically sorted (always), in the main view, depends on your selection

@wvangeit
Copy link
Contributor

Q: I would assume, as a user, that the default sorting should be by "last modified"?

In the tree(s) alphabetically sorted (always), in the main view, depends on your selection

Which also seems to be consistent with how e.g. gdrive allows one to move a folder.

jsaq007
jsaq007 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I agree with @wvangeit. Otherwise approved

services/static-webserver/client/source/class/osparc/dashboard/WorkspacesAndFoldersTree.js Show resolved Hide resolved
sanderegg
sanderegg reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz
Copy link
Member Author

Personally I agree with @wvangeit. Otherwise approved

What do you want me to implement so that I get your approval, sir?

@odeimaiz odeimaiz enabled auto-merge (squash) November 21, 2024 15:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit ba881e9 into ITISFoundation:master Nov 21, 2024
52 checks passed
@odeimaiz odeimaiz deleted the enh/sort-folders-tree branch November 21, 2024 16:09
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Open
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 left review comments

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK approved these changes

@wvangeit wvangeit wvangeit approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Alphabetical list of folders to move to
7 participants
@odeimaiz @wvangeit @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66