Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [e2e-frontend] Service browser #6664

Merged
merged 8 commits into from
Nov 5, 2024
Merged

🎨 [e2e-frontend] Service browser #6664

merged 8 commits into from
Nov 5, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 5, 2024 •
edited
Loading

What do these changes do?

This PR adds e2e-frontend tests for the Service Browser:

  • Make sure that the Services are listed
  • Check the Filters

image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz marked this pull request as ready for review November 5, 2024 09:59
@odeimaiz odeimaiz enabled auto-merge (squash) November 5, 2024 10:09
@odeimaiz odeimaiz self-assigned this Nov 5, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing labels Nov 5, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 5, 2024
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I like that, as we're already used to reading Playwright, it can be easily read in any language.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov reviewed Nov 5, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@odeimaiz odeimaiz merged commit 41817c8 into ITISFoundation:master Nov 5, 2024
50 of 51 checks passed
@odeimaiz odeimaiz deleted the e2e-frontend/service-browser branch November 5, 2024 10:59
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@GitHK GitHK GitHK approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @ignapas @GitHK @pcrespov @matusdrobuliak66