-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Improve Notification texts and Bell's UX #6661
🎨 [Frontend] Improve Notification texts and Bell's UX #6661
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6661 +/- ##
==========================================
- Coverage 87.94% 82.55% -5.40%
==========================================
Files 1564 613 -951
Lines 62982 31345 -31637
Branches 2106 265 -1841
==========================================
- Hits 55389 25876 -29513
+ Misses 7269 5408 -1861
+ Partials 324 61 -263
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔔 thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
services/web/server/src/simcore_service_webserver/users/_notifications.py
Outdated
Show resolved
Hide resolved
…imcore into enh/user-notifications
services/web/server/src/simcore_service_webserver/users/_notifications.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Quality Gate passedIssues Measures |
What do these changes do?
This PR adds two more fields to the Notifications:
resource_id
anduser_from_id
.Thanks to these new fields, the Notification UI element now contains more meaningful information:
Also when tapping the bell, all the notifications will be marked as read.
New UI:
Marked as Read:
Related issue/s
How to test
Dev-ops checklist