-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Avoids raising error when composing disk usage #6660
🐛 Avoids raising error when composing disk usage #6660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR, instead of raising, you are filtering and ignoring. right?
...es/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/system_monitor/_disk_usage.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6660 +/- ##
===========================================
- Coverage 87.85% 68.10% -19.76%
===========================================
Files 1568 613 -955
Lines 63366 31343 -32023
Branches 2089 265 -1824
===========================================
- Hits 55671 21345 -34326
- Misses 7377 9937 +2560
+ Partials 318 61 -257
Continue to review full report in Codecov by Sentry.
|
correct. I have also updated the description of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
What do these changes do?
From real world usage (used and free are differente):
It means that measurements cn be different between two parallel calls (which is feasible since the disk could be used).
A different approach to raising an error would be to remove fields which are not supported (filter them out).
Bonus: deprecated unused code
Related issue/s
How to test
Dev-ops checklist