Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Pydantic V2 migration: various fixes #6647

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2024

What do these changes do?

  • fixed typing issue in aws-library -> green
  • fixed weird assert in resource-usage-tracker + return proper AnyUrl --> green
  • fixed wrong requirement in dynamic-scheduler
  • fixed wrong imports here and there

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work labels Nov 1, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 1, 2024
@sanderegg sanderegg self-assigned this Nov 1, 2024
@sanderegg sanderegg changed the base branch from master to pydantic_v2_migration_do_not_squash_updates November 1, 2024 09:02
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (01769ac) to head (ef80d78).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6647      +/-   ##
===============================================================================
+ Coverage                                        72.17%   72.50%   +0.32%     
===============================================================================
  Files                                             1142     1153      +11     
  Lines                                            50243    51455    +1212     
  Branches                                          1243     1271      +28     
===============================================================================
+ Hits                                             36261    37305    +1044     
- Misses                                           13761    13928     +167     
- Partials                                           221      222       +1     
Flag Coverage Δ *Carryforward flag
integrationtests 64.78% <ø> (-0.01%) ⬇️ Carriedforward from 4121096
unittests 83.87% <50.00%> (+1.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.32% <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.56% <0.00%> (-0.04%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (-0.03%) ⬇️
agent 97.21% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.25% <ø> (ø)
catalog 90.59% <ø> (ø)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 90.84% <ø> (ø)
datcore_adapter 93.14% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 76.22% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.64% <ø> (-0.02%) ⬇️
efs_guardian 90.07% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 79.52% <ø> (-5.63%) ⬇️
payments 92.98% <100.00%> (ø)
resource_usage_tracker 87.34% <100.00%> (∅)
storage 89.63% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 59.70% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01769ac...ef80d78. Read the comment docs.

@sanderegg sanderegg marked this pull request as ready for review November 1, 2024 09:37
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

Copy link

sonarcloud bot commented Nov 1, 2024

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a lot!. From now on, i suggest that we do the sync with our own commits to master. This way you you do not have to be doing this by your own :-)

@sanderegg
Copy link
Member Author

Thx a lot!. From now on, i suggest that we do the sync with our own commits to master. This way you you do not have to be doing this by your own :-)

@Crespov: not sure I understand what you mean here

@sanderegg sanderegg merged commit 2486b38 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 1, 2024
70 of 89 checks passed
@sanderegg sanderegg deleted the various-fixes branch November 1, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants