-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️ Add password authentication for redis ( ⚠️ OPS) #6035
⚗️ Add password authentication for redis ( ⚠️ OPS) #6035
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6035 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1444 +1434
Lines 214 59426 +59212
Branches 25 1409 +1384
=========================================
+ Hits 181 52377 +52196
- Misses 23 6753 +6730
- Partials 10 296 +286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… machines (⚠️ Devops) 🚨 (ITISFoundation#5923)
…tion#6052) Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrei Neagu <[email protected]>
Merged on behalf of @bisgaard-itis . Needed for staging release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Left some suggestions . please consider them before merging.
services/web/server/tests/integration/01/test_exporter_requests_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/application_settings_utils.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/application_settings_utils.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/docker-compose-devel.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added a few comments, but looks good.
** Follow-Up PR for #5708**
What do these changes do?
We would like to use the AWS managed, fully redis-compatible "MemoryDB" in AWS, since we have now introduced non-ephemeral data in redis that should strictly persist even across incidents (CC @GitHK for details). AWS provides MemoryDB (see https://docs.aws.amazon.com/memorydb/latest/devguide/what-is-memorydb-for-redis.html ) as an endpoint/URL, that redis-clients can connect to with password authentication. Up until now, redis was running inside the
simcore
docker stack, isolated from outside connections via docker networks, and simcore services would connect to it directly, unencrypted and without authentication. While there was some infrastructure in the code to allow password authentication, it was not working out-of-the-box.This PR will change the communication of simcore services with redis to always use password authentication.
Bonus:
Related issue/s
Related PRs
Dev-ops checklist