Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in groups plugin #4209

Merged
merged 22 commits into from
May 11, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 9, 2023

What do these changes do?

  • ♻️ refactors groups plugin in webserver
    • plugin under groups folder
    • protected internal modules
    • splits api: moves database layer to a separated module _db
    • replaces mapping OAS -> handlers by static definition of routes (added tests).
    • general code cleanup (e.g. _logger, TODO, ...)

Related issue/s

How to test

cd services/web/server
make mypy | grep groups

@pcrespov pcrespov self-assigned this May 9, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 9, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #4209 (265f2cf) into master (75141d1) will decrease coverage by 7.0%.
The diff coverage is 93.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4209      +/-   ##
=========================================
- Coverage    85.9%   78.9%    -7.0%     
=========================================
  Files         866     396     -470     
  Lines       38414   20562   -17852     
  Branches      583     173     -410     
=========================================
- Hits        33025   16243   -16782     
+ Misses       5253    4270     -983     
+ Partials      136      49      -87     
Flag Coverage Δ
integrationtests 61.9% <64.6%> (-6.8%) ⬇️
unittests 84.0% <92.6%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_service_webserver/groups/exceptions.py 100.0% <ø> (ø)
...core_service_webserver/scicrunch/service_client.py 65.6% <66.6%> (ø)
...c/simcore_service_webserver/groups/_classifiers.py 73.0% <84.0%> (ø)
.../src/simcore_service_webserver/groups/_handlers.py 81.3% <88.0%> (ø)
...server/src/simcore_service_webserver/groups/_db.py 94.8% <94.8%> (ø)
...server/src/simcore_service_webserver/groups/api.py 96.6% <96.6%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
...mcore_service_webserver/garbage_collector_utils.py 83.5% <100.0%> (ø)
...ver/src/simcore_service_webserver/groups/_utils.py 100.0% <100.0%> (ø)
...ver/src/simcore_service_webserver/groups/plugin.py 100.0% <100.0%> (ø)
... and 5 more

... and 568 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4071/mypy-webserver-groups branch 2 times, most recently from deed4cf to 561c0bd Compare May 10, 2023 12:51
@pcrespov pcrespov marked this pull request as ready for review May 10, 2023 12:51
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners May 10, 2023 12:51
@pcrespov pcrespov force-pushed the is4071/mypy-webserver-groups branch from 24e821f to 551a684 Compare May 10, 2023 14:31
@pcrespov pcrespov enabled auto-merge (squash) May 10, 2023 14:33
@pcrespov pcrespov force-pushed the is4071/mypy-webserver-groups branch from 551a684 to 19bc757 Compare May 10, 2023 19:09
@pcrespov pcrespov force-pushed the is4071/mypy-webserver-groups branch from 79ae774 to 5ebff0a Compare May 11, 2023 13:12
@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 265f2cf and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 265e776 into ITISFoundation:master May 11, 2023
@pcrespov pcrespov deleted the is4071/mypy-webserver-groups branch May 11, 2023 15:52
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants