Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds inactivity detection #27

Merged
merged 53 commits into from
Apr 8, 2024
Merged

Adds inactivity detection #27

merged 53 commits into from
Apr 8, 2024

Conversation

GitHK
Copy link
Collaborator

@GitHK GitHK commented Mar 21, 2024 •
edited
Loading

Added integration for activity detection using https://github.com/ITISFoundation/service-activity-monitor

Testing utils utils.zip

Bumped version to 3.0.0 for the inactivity.

@GitHK GitHK requested a review from elisabettai as a code owner March 21, 2024 15:45
@GitHK GitHK self-assigned this Mar 22, 2024
@GitHK GitHK added the type:enhancement New feature or request label Mar 22, 2024
@GitHK GitHK marked this pull request as ready for review March 22, 2024 11:17
@GitHK GitHK requested a review from mguidon March 22, 2024 12:58
elisabettai
elisabettai requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
I haven't tested it yet, but I'll do that once we publish a new version of the service on master.

Will you bump the version, right? I'd go for a major (or even minor version), as this is a potentially breaking change of the behavior.

elisabettai
elisabettai reviewed Apr 5, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@GitHK GitHK requested a review from elisabettai April 8, 2024 11:27
elisabettai
elisabettai approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, it looks great!

@GitHK GitHK merged commit e4c83b6 into main Apr 8, 2024
2 checks passed
@GitHK GitHK deleted the adds-inactivity-detection branch April 8, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabettai elisabettai elisabettai approved these changes

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@GitHK GitHK

Labels
type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitHK @elisabettai