장식초를 구매할 수 있고, 편지를 작성하면 포인트를 얻는다. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieun32
commented
Jul 16, 2024
| }} | ||
| > | ||
| {candle.point === 0 && <CandleBadge>free</CandleBadge>} | ||
| {candle.point !== 0 && <CandleBadge>{candle.point}p</CandleBadge>} |
There was a problem hiding this comment.
여기는 이렇게 바꿔야겠습니닷 다음 PR때 반영할게요오!
<CandleBadge>{candle.point === 0 ? free : ${candle.point}P}</CandleBadge>
kyr4601
approved these changes
Jul 16, 2024
hyunmindev
reviewed
Jul 16, 2024
| <ColorContainer> | ||
| {colors.map((color, index) => ( | ||
| <ColorOption | ||
| key={index} |
There was a problem hiding this comment.
key를 index로 지정하는 것은 최후의 수단입니다.
color도 유니크한 데이터 아닌가요?
hyunmindev
reviewed
Jul 16, 2024
Comment on lines
+28
to
+38
| const letter = LetterResponseType.parse( | ||
| await createLetter({ | ||
| senderId, | ||
| recipientId, | ||
| candleId, | ||
| nickname, | ||
| contents, | ||
| keyword, | ||
| year, | ||
| }), | ||
| ); |
There was a problem hiding this comment.
최대한 한줄로 처리하려는 사람을 one-liner라고 해요 가독성에 좋지 않은 안티패턴입니다.
hyunmindev
reviewed
Jul 16, 2024
| const { point } = req.body; | ||
|
|
||
| try { | ||
| const user = UserType.parse(await subtractPoint(userId, Number(point))); |
hyunmindev
reviewed
Jul 16, 2024
| } | ||
| } | ||
|
|
||
| // letter/create/ownerId?candleId=123 |
hyunmindev
reviewed
Jul 16, 2024
| return res.data; | ||
| } | ||
| } catch (error) { | ||
| console.log(error); |
hyunmindev
reviewed
Jul 16, 2024
Comment on lines
+73
to
+78
| fetchUserInfo().then((data) => { | ||
| if (data) { | ||
| setSenderId(data.userId); | ||
| setNickname(data.nickname); | ||
| } | ||
| }); |
There was a problem hiding this comment.
(스타일) 즉시 실행함수로 async await을 사용할 수도 있습니다.
hyunmindev
reviewed
Jul 16, 2024
| <input | ||
| type="text" | ||
| value={nickname} | ||
| style={{ marginBottom: '10px', width: '50%', height: '2rem' }} |
hyunmindev
reviewed
Jul 16, 2024
There was a problem hiding this comment.
이런 svg는 차라리 외부리소스로 따로 분리하시고 lazy하게 가져오세요 inline svg로 넣기엔 너무 커요.
hyunmindev
reviewed
Jul 16, 2024
| if (error.response?.status === 401) { | ||
| return null; | ||
| } else { | ||
| throw new Error(`${error}`); |
There was a problem hiding this comment.
TS를 사용할때 이러한 암시적 형변환은 일반적으로 사용하지 않습니다. 명시적으로 형변환 하세요.
hyunmindev
reviewed
Jul 16, 2024
Comment on lines
+18
to
+24
| <Button | ||
| type="default" | ||
| label="로그인하러 가기" | ||
| onClick={() => { | ||
| navigate('/'); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
이런 형태의 button이 많이 반복되고 있는데, Link 컴포넌트를 만드는 것은 어떨까요?
hyunmindev
reviewed
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 유형 선택
✨ 기능 추가🐛 버그 수정🖼️ UI 변경🫧 코드 리팩토링✅ 테스트 코드 추가📦 기타 (문서, CI/CD, 되돌리기, 포맷팅 …)작업 내용
관련 문서
7월 16일 스크럼
리뷰 요구사항 (선택)