Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Add to mine" Button #7

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Added "Add to mine" Button #7

merged 4 commits into from
Aug 23, 2023

Conversation

seongjinyoon
Copy link
Collaborator

Description

This PR implements the functionality for the Add to mine button, allowing users to add suggested rules and modify them.
By pressing the Add to mine button, users can edit the suggested query and save it as their own Rewriting Rule.

Screenshot 2023-08-21 at 4 35 48 PM

Changes Made

  • Added Add to mine button functionalities inside QuerySuggestionRewritingPath.js
  • Modified RewritingRuleModal.js to allow queries to be shown in the modal.
  • QueryLogs.js: added attribute user for NiceModal to allow the query to be saved given the user.id

@seongjinyoon seongjinyoon requested a review from baiqiushi August 21, 2023 23:44
Copy link
Contributor

@baiqiushi baiqiushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We merge the current shape and keep a TODO as an issue.

@baiqiushi baiqiushi merged commit 006fbd3 into main Aug 23, 2023
@baiqiushi baiqiushi deleted the feature/add-to-mine-button branch August 23, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants