Fix CI issues and workflows #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thlehmann-ionos
force-pushed
the
tl/dev/fix-ci-issues-and-workflows
branch
from
b7e7dd4 to
c4ad33b
Compare
thlehmann-ionos
force-pushed
the
tl/dev/fix-ci-issues-and-workflows
branch
2 times, most recently
from
003049d to
7c8b392
Compare
Despite the current RC being 30.x tests enabling the app on master fail with version 30.
I opted for tabs because Nextcloud use mostly tabs in their psalm.xml too.
* Use the same error level as Nextcloud core * Reduce initial number of issues from ~70 to ~20
Just for food measure, doesn't seem to have an effect on detected issues.
As they only create unfixable Psalm noise.
By the public exception.
UndefinedClass: Since we're referencing the private implementation Psalm can't "see" the interface.
Psalm complains Method (OCP\Authentication\Token\IToken&OC\Authentication\Token\INamedToken)::setName does not exist due to findTokenByIdAndUser() returning IToken, which is too closed and does not contain setName() declared by INamedToken. Extending the type range allows Psalm to "see" setName()
To ignore issue that this class is not used.
As they only create unfixable Psalm noise.
This causes Psalm issues because it can not find IAuthTokenProvider. Apparently it's not able to know that this type was imported as another name.
Otherwise Psalm would complain OC\Authentication\Token\IToken does not contain OC\Authentication\Token\INamedToken which is understandable.
thlehmann-ionos
force-pushed
the
tl/dev/fix-ci-issues-and-workflows
branch
from
7c8b392 to
59a17b4
Compare
1 task
|
Would propose to fix here also deprecations warning for unit tests in apps-custom/simplesettings/tests/Controller/AuthSettingsControllerTest.php:296 and apps-custom/simplesettings/tests/Controller/AuthSettingsControllerTest.php:253 so unit tests will get green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest problems still:
We reference private/internal Nextcloud types from the
OC\namespace, which are officially not visible - with this PR we add ignores for them