-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(software): improve smartphone layout #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically OK for me with
- some upfront refactorings (declare scss language, combine repeated styles)
- refactorings to use variables
- proposal
- to add a gap between the buttons
- to wrap the QR codes
I'd appreciate you pick at least the first two and maybe the button gap fix too.
See [my review branch tl/review/kh/dev/app-links-layout/
].
Let's discuss if there are more question. I'm fine if you want to simplify things even more. 👍
7bbdbe7
to
4d716be
Compare
Signed-off-by: Thomas Lehmann <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
4d716be
to
462886b
Compare
Sign-off added to my commit, typo in another commit message fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review OK if you amend 0b2c4f9 as discussed in person.
Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
0b2c4f9
to
39c7703
Compare
No description provided.