Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(software): improve smartphone layout #39

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

bromiesTM
Copy link
Contributor

No description provided.

Copy link
Collaborator

@thlehmann-ionos thlehmann-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically OK for me with

  • some upfront refactorings (declare scss language, combine repeated styles)
  • refactorings to use variables
  • proposal
    • to add a gap between the buttons
    • to wrap the QR codes

I'd appreciate you pick at least the first two and maybe the button gap fix too.

See [my review branch tl/review/kh/dev/app-links-layout/].

Let's discuss if there are more question. I'm fine if you want to simplify things even more. 👍

@bromiesTM bromiesTM force-pushed the kh/dev/app-links-layout branch 2 times, most recently from 7bbdbe7 to 4d716be Compare August 14, 2024 08:35
@thlehmann-ionos thlehmann-ionos force-pushed the kh/dev/app-links-layout branch from 4d716be to 462886b Compare August 14, 2024 13:38
@thlehmann-ionos
Copy link
Collaborator

Sign-off added to my commit, typo in another commit message fixed.

Copy link
Collaborator

@thlehmann-ionos thlehmann-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK if you amend 0b2c4f9 as discussed in person.

@bromiesTM bromiesTM force-pushed the kh/dev/app-links-layout branch from 0b2c4f9 to 39c7703 Compare August 15, 2024 07:28
@bromiesTM bromiesTM merged commit 5a46b3a into master Aug 15, 2024
14 of 25 checks passed
@bromiesTM bromiesTM deleted the kh/dev/app-links-layout branch August 15, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants