Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install @typescript-eslint/eslint-plugin #19

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: install @typescript-eslint/eslint-plugin #19

merged 1 commit into from
Jul 9, 2024

Conversation

thlehmann-ionos
Copy link
Collaborator

@thlehmann-ionos thlehmann-ionos commented Jul 8, 2024 •
edited
Loading

As workaround for missing dependency in @nextcloud/eslint-config.

@nextcloud/eslint-config configures the plugin through its

"parser": "@typescript-eslint/parser"

config in parts/typescript.jsi 1, yet does not specify the dependency 2

This is a workaround on our side and should be fixed in @nextcloud/eslint-config.

Steps to reproduce

  1. Clear Nextcloud server's node_modules
  2. Clear App's node_modules
  3. npm ci
  4. Build
simplesettings $ rm -rf ../../node_modules/*
simplesettings $ rm -rf node_modules/* ; npm ci ; npm --version
simplesettings $ npm run build ; npm run lint

@thlehmann-ionos
fix: install @typescript-eslint/eslint-plugin
085a81e 
As workaround for missing dependency in @nextcloud/eslint-config.

@nextcloud/eslint-config configures the plugin through its

   "parser": "@typescript-eslint/parser"

config in parts/typescript.jsi [1], yet does not specify the dependency [2]

[1]: https://github.com/nextcloud-libraries/eslint-config/blob/v8.4.1/parts/typescript.js#L8
[2]: https://github.com/nextcloud-libraries/eslint-config/blob/v8.4.1/package.json#L15
@thlehmann-ionos thlehmann-ionos mentioned this pull request Jul 8, 2024
Merged
bromiesTM
bromiesTM approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ok

@thlehmann-ionos thlehmann-ionos merged commit 9f367f0 into master Jul 9, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bromiesTM bromiesTM bromiesTM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thlehmann-ionos @bromiesTM