Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide apps #10

Merged
merged 5 commits into from
Jul 8, 2024
Merged

provide apps #10

merged 5 commits into from
Jul 8, 2024

Conversation

fracado
Copy link
Contributor

@fracado fracado commented Jul 4, 2024

add product software links for mobile (iOS, android) and desktop (MacOS, Windows)

@fracado fracado changed the title Fb/dev/provide apps provide apps Jul 4, 2024
Copy link
Contributor

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok with amends

I'd suggest to reword the commit messages to align to conventional commit format, as thats a requirement for the public nc repo. there even is a GitHub Action to check if the commits comply to the format in this repo :)

img/mobileAppStore.svg Outdated Show resolved Hide resolved
src/components/files/Software.vue Outdated Show resolved Hide resolved
src/components/files/Software.vue Outdated Show resolved Hide resolved
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/webpack-vue-2-typescript branch 4 times, most recently from 830b6e4 to 1a5fad8 Compare July 5, 2024 13:44
@fracado fracado force-pushed the fb/dev/provide-apps branch from 8f98174 to bb404ae Compare July 5, 2024 13:52
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/webpack-vue-2-typescript branch from 1a5fad8 to f331537 Compare July 5, 2024 13:56
@fracado fracado force-pushed the fb/dev/provide-apps branch from bb404ae to 00cd433 Compare July 5, 2024 14:02
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/webpack-vue-2-typescript branch from f331537 to 637ec91 Compare July 5, 2024 14:03
@fracado fracado force-pushed the fb/dev/provide-apps branch from 00cd433 to 730c8ce Compare July 5, 2024 14:05
@thlehmann-ionos thlehmann-ionos force-pushed the tl/dev/webpack-vue-2-typescript branch 2 times, most recently from 3ce55b8 to 851c693 Compare July 5, 2024 14:14
@fracado fracado force-pushed the fb/dev/provide-apps branch from 730c8ce to 8a0f8b2 Compare July 5, 2024 14:31
@thlehmann-ionos
Copy link
Collaborator

  • Please add the license banner (see WebDavUrl.vue for example, add only your name in the "tag")
  • Please move the component to a different subfolder (i.e. help, since it's supposed to be categorized under such a menu point later)
  • Please "sign off" each commit (git commit --amend --signoff)
    You could do this in bulk with:
    git rebase -i 637ec91  --exec 'git commit --amend --no-edit --signoff'
    

@fracado fracado force-pushed the fb/dev/provide-apps branch from 8a0f8b2 to 591d8d3 Compare July 5, 2024 16:51
@fracado fracado changed the base branch from tl/dev/webpack-vue-2-typescript to master July 8, 2024 09:49
fracado added 2 commits July 8, 2024 11:51
Signed-off-by: Franziska Bath <[email protected]>
@fracado fracado force-pushed the fb/dev/provide-apps branch from 591d8d3 to bae7ff2 Compare July 8, 2024 09:51
fracado added 3 commits July 8, 2024 11:55
components/Software: add link buttons and QRcode

Signed-off-by: Franziska Bath <[email protected]>
translationtool throws an error if xml file contains a tag that only contains a comment.

Signed-off-by: Franziska Bath <[email protected]>
@fracado fracado force-pushed the fb/dev/provide-apps branch from bae7ff2 to 19619e8 Compare July 8, 2024 09:56
@fracado fracado merged commit 0b39320 into master Jul 8, 2024
12 of 15 checks passed
@fracado fracado deleted the fb/dev/provide-apps branch July 8, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants