Kh/dev/layout of external share #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slotted content will always be rendered even if inside an if block See https://svelte.dev/docs/svelte/custom-elements#Caveats-and-limitations Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/layout-of-external-share
branch
from
9b9f309 to
d543dc0
Compare
By removing the need for pre-defined named slots Signed-off-by: Kai Henseler <[email protected]>
Signed-off-by: Kai Henseler <[email protected]>
As the action is now slotted into the custom header, the .header-right class is no longer available. Styling the slotted button from inside the Header did not work for me (::slotted), therefore changing the selector is necessary. Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/layout-of-external-share
branch
from
d543dc0 to
5ccd59a
Compare
5 tasks
bromiesTM
commented
Jan 17, 2025
bromiesTM
force-pushed
the
kh/dev/layout-of-external-share
branch
from
48d895c to
c2aa306
Compare
Signed-off-by: Kai Henseler <[email protected]>
bromiesTM
force-pushed
the
kh/dev/layout-of-external-share
branch
from
c2aa306 to
4565171
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
according to UX design Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
printminion-co
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::slottedselector did not work for me, but I'd be happy to find a better solution that overriding thepublicpage.js