Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades client dependencies #945

Closed
wants to merge 0 commits into from
Closed

Upgrades client dependencies #945

wants to merge 0 commits into from

Conversation

atomicgamedeveloper
Copy link
Contributor

Upgrading the project's dependencies as specified in issue #893.

@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper

Thanks for the PR. Please look into the following suggestions.

  1. Upgrade all dependencies to th latest versions available. Choose an earlier version only if there is a breaking compatibility issues.
  2. Keep the first letter of a function in lowercase and that of class in uppercase. I know the distinction is a bit thin in Javadcript but keeping the distinction hopefully aids the readability.
  3. There are many minor formatting changes. Are they the outcome of yarn format command?

@prasadtalasila prasadtalasila changed the title Upgrades dependencies Upgrades client dependencies Sep 26, 2024
@prasadtalasila prasadtalasila mentioned this pull request Sep 27, 2024
Merged
@atomicgamedeveloper atomicgamedeveloper marked this pull request as ready for review October 2, 2024 18:25
prasadtalasila
prasadtalasila reviewed Oct 7, 2024
View reviewed changes
client/package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@into-cps-association/dtaas-web",
"version": "0.4.1",
"version": "0.4.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump it up to 0.5.1

@prasadtalasila
Copy link
Contributor

The Github action of libms has been improved to include checks on both Windows and Linux OS environments. Please add this change to client as well.

@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper please let me know when this PR is ready for my next review. Thanks.

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Oct 11, 2024
prasadtalasila
prasadtalasila reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomicgamedeveloper Thanks for the updates. Please see the new comments.

client/package.json Outdated Show resolved Hide resolved
client/package.json Outdated
"rimraf": "6.0.1",
"serve": "14.2.4",
"styled-components": "6.1.13",
"typescript": "5.1.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this go any higher even for a lower version of a eslint?

client/package.json Outdated
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-syntax-flow": "7.25.7",
"@babel/plugin-transform-react-jsx": "7.25.7",
"@eslint/eslintrc": "3.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using eslintrc anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe client/eslint.config.mjs uses it on line 10 for migration purposes.

import { FlatCompat } from "@eslint/eslintrc";

client/package.json Outdated
"@eslint/js": "9.12.0",
"@playwright/test": "1.48.1",
"@testing-library/dom": "10.4.0",
"@testing-library/jest-dom": "6.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 6.6.1 now

client/test/preview/integration/components/asset/AssetBoard.test.tsx Outdated
middleware: getDefaultMiddleware({
serializableCheck: false,
}),
middleware: (getDefaultMiddleware) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of this change?

client/src/preview/route/digitaltwins/DigitalTwinsPreview.tsx Outdated
@@ -66,16 +66,17 @@ export const createDigitalTwinsForAssets = async (
});
};

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might not be needed?

client/src/preview/route/digitaltwins/execute/pipelineHandler.ts Outdated
@@ -71,7 +71,7 @@ export const handleStop = async (
} catch (error) {
dispatch(
showSnackbar({
message: `Execution stop failed for ${formatName(digitalTwin.DTName)}`,
message: `Execution stop failed for ${formatName(digitalTwin.DTName)}. ${error}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an advantage to adding ${error} here?

@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper
There is a problem with the client dependency upgrade PR. It broke two things.

  1. yarn gitlab:compile && yarn gitlab:run (please see end of DEVELOPER.md for explanation of these two commands)
  2. The Digital Twin Preview page (this is undocumented. Perhaps @VanessaScherma can take a meeting with you to cross check the problem)

@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper please rebase to feature/distributed-demo branch

@codeclimate CodeClimate
Copy link

codeclimate bot commented Oct 30, 2024

Code Climate has analyzed commit 8788139 and detected 0 issues on this pull request.

View more on Code Climate.

@atomicgamedeveloper atomicgamedeveloper mentioned this pull request Nov 1, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@prasadtalasila prasadtalasila prasadtalasila left review comments

Assignees
No one assigned
Labels
None yet
Projects
Digital Twin as a Service
Archived in project
Milestone
Release v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@atomicgamedeveloper @prasadtalasila