Add 'Execute' tab to Digital Twins page preview #903

VanessaScherma · 2024-09-10T14:03:50Z

It replaces PR #891. It completes the Execute tab present on the Digital twins page preview, which is accessible from the appropriate link within the Workbench. Only some unit tests are still incomplete due to the library import error.

codeclimate

The PR diff size of 6946 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 7108 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 7093 lines exceeds the maximum allowed for the inline comments feature.

prasadtalasila · 2024-09-12T12:44:56Z

@VanessaScherma suggestions to improve the PR:

Remove job number from status messages. Only store the latest log in the browser cache.
Write about the need to add "pipeline trigger token" in GITLAB-RUNNER.md
Do not "busy wait" for job logs. Have a 5 second wait between sequential log requests.
If the job execution takes too long (how long?), the DT execution "Start" button is active forever.

Also replace text at the top of "Execute" Tab with the following

"This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work."

codeclimate

The PR diff size of 7103 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 7245 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 7817 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5149 lines exceeds the maximum allowed for the inline comments feature.

codeclimate

The PR diff size of 5072 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2024-10-03T15:32:51Z

client/src/preview/route/digitaltwins/execute/pipelineUtils.ts

+    if (typeof log === 'string') {
+      log
+        .replace(
+          // TODO: Fix ansi character stripping


prasadtalasila

@VanessaScherma please check the comments. Thanks for the updates.

client/config/test.js

prasadtalasila · 2024-10-03T15:38:55Z

client/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@into-cps-association/dtaas-web",
-  "version": "0.4.0",
+  "version": "0.4.1",


This should be 0.5.0

prasadtalasila · 2024-10-03T15:39:50Z

client/package.json

@@ -71,6 +75,7 @@
    "react-redux": "^8.1.3",
    "react-router-dom": "^6.20.0",
    "react-scripts": "^5.0.1",
+    "react-syntax-highlighter": "^15.5.0",


not required in this PR

client/src/preview/components/asset/AssetBoard.tsx

client/src/store/store.ts

client/src/util/gitlab.ts

prasadtalasila · 2024-10-03T16:34:00Z

client/src/util/gitlabDigitalTwin.ts

please move this file to preview/util/gitlabDigitalTwin.ts. But we will do pair programming to move the gitlabDriver.ts

Should I move the gitlabDriver.ts now?

Yes, that will be helpful.

prasadtalasila · 2024-10-03T17:24:27Z

client/src/preview/route/digitaltwins/execute/pipelineChecks.ts

Please give better names to checkFirstPipelineStatus and checkSecondPipelineStatus.

Changed into checkParentPipelineStatus and checkChildPipelineStatus.

prasadtalasila · 2024-10-03T17:27:43Z

client/src/preview/route/digitaltwins/execute/pipelineHandler.ts

+      digitalTwin.gitlabInstance.projectId,
+      digitalTwin.pipelineId,
+    );
+    await digitalTwin.stop(


why is this being called twice?

To stop both the parent pipeline and the child pipeline.

Thanks. I guess the change of function names makes this point clear.

Please provide pipeline name instead of pipelineId. The names can be parent pipeline and child pipeline. Perhaps there can be a mapping from name to id?

prasadtalasila · 2024-10-05T14:17:04Z

@VanessaScherma
The yarn syntax is throwing up errors. The .eslintignore file needs to be updated with the following content.

api/
build/
config/
node_modules/
script/
coverage/
dist/
test-results/
playwright-report/
public/

prasadtalasila · 2024-10-05T15:08:59Z

Since the gitlabDriver.ts has moved, the jest.config.ts needs to be updated as well.

....
  "coveragePathIgnorePatterns": [
    ...
    "src/preview/util/gitlabDriver.ts"
  ],
....

prasadtalasila · 2024-10-05T19:08:55Z

@VanessaScherma The following changes are required for package.json.

{
  ...
  "contributors": [
    ...
    "Cesar Vela",
    "Vanessa Scherma"
  ],
  ...
  "scripts": {
    "build": "npx react-scripts build",
    "clean": "npx rimraf build/ dist/ node_modules/ coverage/ playwright-report/ test-results/  test.svg src.svg src/util/gitlab.json",
    ...
    "develop": "npx react-scripts start",
    ...
    "gitlab:compile": "npx tsc --project tsconfig.gitlab.json",
    ...
  },
  ...
}

Please double check the proposed changes by running all the yarn commands suggested in DEVELOPER.md. Thanks.

codeclimate · 2024-10-06T17:05:46Z

Code Climate has analyzed commit 9938e33 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Bug Risk	1

View more on Code Climate.

codecov · 2024-10-06T17:08:37Z

Codecov Report

Attention: Patch coverage is 33.69565% with 244 lines in your changes missing coverage. Please review.

Project coverage is 64.82%. Comparing base (eaa22d5) to head (9938e33).
Report is 30 commits behind head on feature/distributed-demo.

Files with missing lines	Patch %	Lines
client/src/preview/util/gitlabDigitalTwin.ts	6.52%	40 Missing and 3 partials ⚠️
client/src/preview/util/gitlab.ts	9.30%	35 Missing and 4 partials ⚠️
...eview/route/digitaltwins/execute/pipelineChecks.ts	25.00%	27 Missing and 6 partials ⚠️
...preview/route/digitaltwins/DigitalTwinsPreview.tsx	37.50%	28 Missing and 2 partials ⚠️
...review/route/digitaltwins/execute/pipelineUtils.ts	25.00%	22 Missing and 2 partials ⚠️
...view/route/digitaltwins/execute/pipelineHandler.ts	27.58%	18 Missing and 3 partials ⚠️
client/src/preview/store/digitalTwin.slice.ts	35.29%	8 Missing and 3 partials ⚠️
client/src/preview/components/asset/AssetCard.tsx	62.96%	10 Missing ⚠️
client/src/preview/components/asset/AssetBoard.tsx	57.14%	5 Missing and 1 partial ⚠️
client/src/preview/route/digitaltwins/Snackbar.tsx	53.84%	6 Missing ⚠️
... and 6 more

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/distributed-demo     #903      +/-   ##
============================================================
- Coverage                     66.49%   64.82%   -1.68%     
============================================================
  Files                            31       48      +17     
  Lines                           394      813     +419     
  Branches                         26       59      +33     
============================================================
+ Hits                            262      527     +265     
- Misses                          117      244     +127     
- Partials                         15       42      +27

Files with missing lines	Coverage Δ
client/src/components/LinkIconsLib.tsx	`100.00% <100.00%> (ø)`
...ew/route/digitaltwins/DigitalTwinTabDataPreview.ts	`100.00% <100.00%> (ø)`
client/src/routes.tsx	`100.00% <100.00%> (ø)`
client/src/preview/store/assets.slice.ts	`83.33% <83.33%> (ø)`
client/src/util/envUtil.ts	`82.05% <66.66%> (-0.81%)`	⬇️
client/src/preview/components/asset/LogButton.tsx	`57.14% <57.14%> (ø)`
...t/src/preview/components/asset/StartStopButton.tsx	`58.33% <58.33%> (ø)`
...c/preview/route/digitaltwins/execute/LogDialog.tsx	`58.33% <58.33%> (ø)`
client/src/preview/components/asset/AssetBoard.tsx	`57.14% <57.14%> (ø)`
client/src/preview/route/digitaltwins/Snackbar.tsx	`53.84% <53.84%> (ø)`
... and 9 more

... and 6 files with indirect coverage changes

Components	Coverage Δ
Website	`64.82% <43.82%> (-1.68%)`	⬇️
Lib Microservice	`∅ <ø> (∅)`

VanessaScherma · 2024-10-06T17:14:55Z

I have applied the requested changes. The commands in DEVELOPER.md work correctly.

prasadtalasila and others added 7 commits September 9, 2024 10:41

manual rebase in progress

699a0dc

manual rebase in progress

25158f3

completes manual rebase

3dcbd9b

Delete old components

eccae19

Add properties to gitlabDigitalTwin

4b54723

Add unit tests

e3bce4c

Complete documentation

3ab550f

codeclimate bot reviewed Sep 10, 2024

View reviewed changes

Fix codeclimate issues

447ff03

codeclimate bot reviewed Sep 10, 2024

View reviewed changes

Refactor ExecutionFunctions

2f5d458

codeclimate bot reviewed Sep 10, 2024

View reviewed changes

prasadtalasila mentioned this pull request Sep 11, 2024

Digital Twins page preview - trigger pipeline from client #891

Closed

Remove strip-ansi and add instructions to gitlab-runner

656ca9a

codeclimate bot reviewed Sep 12, 2024

View reviewed changes

Apply comments

5ba4ebf

codeclimate bot reviewed Sep 13, 2024

View reviewed changes

Start unit testing and use preview folders

b56730b

codeclimate bot reviewed Sep 14, 2024

View reviewed changes

vanessa added 8 commits September 14, 2024 17:02

Add Manage tab files

a43f972

Change components and use redux

577b320

Update unit tests

39d8deb

Format

afe4d4f

Fix codeclimate issues

34a9709

Use remarkable library

38c0329

Add Reconfigure Dialog

f3bb71d

Complete Reconfigure dialog

3b66b29

prasadtalasila added this to the Release v0.6.0 milestone Sep 20, 2024

Unit testing

684b4f2

vanessa added 2 commits October 3, 2024 17:07

Resolve conflicts

30088d6

Resolve conflicts

10fef9e

codeclimate bot reviewed Oct 3, 2024

View reviewed changes

Resolve conflicts

6465b26

codeclimate bot reviewed Oct 3, 2024

View reviewed changes

vanessa added 2 commits October 3, 2024 17:31

Resolve yarn.lock conflict

3552dfe

Resolve yarn.lock conflict

c892111

codeclimate bot reviewed Oct 3, 2024

View reviewed changes

Checkout yarn.lock

eae696e

prasadtalasila reviewed Oct 3, 2024

View reviewed changes

vanessa and others added 10 commits October 4, 2024 19:44

Resolve review comments

388d36f

Checkout files from feature/distributed-demo branch

4ce2ff4

Use pipeline names instead of pipeline id in stop function

458eb2f

Update unit test

2935ecd

Move gitlabDriver.ts into preview folder

9e6a62c

Configuration fix

76709d5

Configuration fix

acb33e0

Checkout yarn.lock

60d6723

Merge branch 'feature/distributed-demo' into execute-DTs-on-gitlab

44b3038

Little fix in gitlabDriver.ts

a3d1925

prasadtalasila mentioned this pull request Oct 5, 2024

More tasks in github actions #953

Open

vanessa added 2 commits October 6, 2024 18:53

Update .eslintignore

a445cf5

Update package.json and jest.config.json

9938e33

prasadtalasila merged commit 865c74b into INTO-CPS-Association:feature/distributed-demo Oct 7, 2024
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'Execute' tab to Digital Twins page preview #903

Add 'Execute' tab to Digital Twins page preview #903

VanessaScherma commented Sep 10, 2024

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

prasadtalasila commented Sep 12, 2024

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot left a comment

codeclimate bot Oct 3, 2024

prasadtalasila left a comment

prasadtalasila Oct 3, 2024

prasadtalasila Oct 3, 2024

prasadtalasila Oct 3, 2024

VanessaScherma Oct 4, 2024

prasadtalasila Oct 4, 2024

VanessaScherma Oct 5, 2024

prasadtalasila Oct 3, 2024

VanessaScherma Oct 4, 2024

prasadtalasila Oct 3, 2024

VanessaScherma Oct 4, 2024

prasadtalasila Oct 4, 2024

prasadtalasila Oct 4, 2024

VanessaScherma Oct 5, 2024

prasadtalasila commented Oct 5, 2024

prasadtalasila commented Oct 5, 2024

prasadtalasila commented Oct 5, 2024

codeclimate bot commented Oct 6, 2024

codecov bot commented Oct 6, 2024 •

edited

Loading

VanessaScherma commented Oct 6, 2024

Add 'Execute' tab to Digital Twins page preview #903

Add 'Execute' tab to Digital Twins page preview #903

Conversation

VanessaScherma commented Sep 10, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

prasadtalasila commented Sep 12, 2024

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot Oct 3, 2024

Choose a reason for hiding this comment

prasadtalasila left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prasadtalasila commented Oct 5, 2024

prasadtalasila commented Oct 5, 2024

prasadtalasila commented Oct 5, 2024

codeclimate bot commented Oct 6, 2024

codecov bot commented Oct 6, 2024 • edited Loading

Codecov Report

VanessaScherma commented Oct 6, 2024

codecov bot commented Oct 6, 2024 •

edited

Loading