auth revoke #500
auth revoke #500
Conversation
|
Code Climate has analyzed commit 5bb1a20 and detected 0 issues on this pull request. View more on Code Climate. |
|
@aryanbhosale The signout does not happen. The application behavior is same as before. |
| @@ -7,6 +7,9 @@ import { getLogoutRedirectURI } from '../envUtil'; | |||
| export interface CustomAuthContext { | |||
| signoutRedirect: () => Promise<void>; | |||
| removeUser: () => Promise<void>; | |||
There was a problem hiding this comment.
I am curious about the need for these empty functions. Do you know why?
There was a problem hiding this comment.
these are just placeholders that i created as i was reading through the docs of oidc, later realising that theyre not used anywhere
There was a problem hiding this comment.
There is no change in package.json. This file need not be changed.
| @@ -29,7 +32,10 @@ export async function signOut() { | |||
| localStorage.clear(); | |||
| sessionStorage.clear(); | |||
|
|
|||
| auth.stopSilentRenew(); | |||
There was a problem hiding this comment.
Please only use the functions that are needed and remove the rest.
There was a problem hiding this comment.
@aryanbhosale Thanks for the PR. Please add tests as well.
There was a problem hiding this comment.
Please only use the functions that are needed and remove the rest.
the stopSilent function ensures that it doesnt try to renew the token once it's logged out
No description provided.