-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display relevant OAuth information on accounts page #499
Display relevant OAuth information on accounts page #499
Conversation
</> | ||
), | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broader comments:
- There does not seem to be any change on the profile pages. Please check.
- The codeclimate issues need to be resolved
label: 'Profile', | ||
body: ( | ||
<> | ||
Profile - potentially visible to other users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove these two lines
<br></br> | ||
See more details on{' '} | ||
<a href={auth.user?.profile.profile}>SSO OAuth provider.</a> | ||
</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the groups text and code here. The exact text is available in issue #478
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added it in the conditional when the user is part of group/groups, this is the accounTabs constant content when he is not part of any of them
client/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There aren't any changes in the package.json dependencies. Is there any particular reason for updating this file?
e92186d
to
375d3a9
Compare
…rify the working of the same
body: <>Account settings - private to a user.</>, | ||
}, | ||
]; | ||
function AccountTabs() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function AccountTabs
has 38 lines of code (exceeds 25 allowed). Consider refactoring.
…rify the working of the same
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## feature/distributed-demo #499 +/- ##
============================================================
+ Coverage 63.38% 65.67% +2.29%
============================================================
Files 31 31
Lines 396 405 +9
Branches 26 31 +5
============================================================
+ Hits 251 266 +15
+ Misses 130 124 -6
Partials 15 15
|
Code Climate has analyzed commit 5093940 and detected 0 issues on this pull request. View more on Code Climate. |
@anshhhhhhh you added the number of groups a user belongs to. Listing of these user groups is needed instead. Thanks. |
@anshhhhhhh |
No description provided.