Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Documentation added #114

Conversation

astitva1905
Copy link
Collaborator

Added developer documentation:

  • Development workflow and intro in index.md
  • Testing folder with documentation for tests
  • architecture additions to system folder
  • puml files convereted to mermaid


We follow a testing workflow in accordance with [The Test Pyramid](https://martinfowler.com/articles/practical-test-pyramid.html#TheTestPyramid), starting with isolated tests and moving towards complete integration for any new feature changes. The different types of tests (in the order that they should be performed) are explained below:

TODO -> DOnt link.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO found

Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the changes made in this branch. You can merge those changes and resolve the comments given here.

There are some markdown linting problems. These are not being shown by codeclimate. Can you please check this? Thanks.

docs/developer/system/c4l3.png Outdated Show resolved Hide resolved
docs/developer/system/client.md Show resolved Hide resolved
## Lib-MS Architecture

### Class Architecture
```mermaid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mermaid diagrams are not being shown in the generated site. I guess the mkdocs.yml and mkdocs-github.yml need to be updated for generating these diagrams.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, added configuration. Please have a look.

docs/developer/workflow.png Outdated Show resolved Hide resolved
docs/developer/system/lib-ms.md Show resolved Hide resolved
docs/developer/system/architecture.md Outdated Show resolved Hide resolved
docs/developer/system/architecture.md Show resolved Hide resolved
@@ -114,4 +114,4 @@ You can run this script multiple times until the installation is successful.

## Access the application

Now you should be able to access the DTaaS application at: <http:>_https://foo.com_</http:>
Now you should be able to access the DTaaS application at: _https://foo.com_
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bare URL used


To manage collaboration by multiple developers on the software, a simple [Fork, Branch, PR](https://gun.io/news/2017/01/how-to-github-fork-branch-and-pull-request/) development workflow is in place. Each developer should follow these steps:

1. Have an updated fork of the main repository on their account. This should also be added to codeclimate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

```
git clone https://github.com/<yourgithubusername>/DTaaS.git
```
1. Work on your issue/feature on your personal computer.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

1. Work on your issue/feature on your personal computer.

1. Any updates/additions to the software should first be committed to your personal fork.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces


## Operating Softwares

Ideally, developers should work on Ubuntu/Linux. Other operating systems are not supported inherently and may require additional steps.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length


## Code Editing

Any popular code editors can be used to work on the project. VS Code, Sublime Text are a few examples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length


## Development Workflow

To manage collaboration by multiple developers on the software, a simple [Fork, Branch, PR](https://gun.io/news/2017/01/how-to-github-fork-branch-and-pull-request/) development workflow is in place. Each developer should follow these steps:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length


To manage collaboration by multiple developers on the software, a simple [Fork, Branch, PR](https://gun.io/news/2017/01/how-to-github-fork-branch-and-pull-request/) development workflow is in place. Each developer should follow these steps:

1. Have an updated fork of the main repository on their account. This should also be added to codeclimate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

```
1. Work on your issue/feature on your personal computer.

1. Any updates/additions to the software should first be committed to your personal fork.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length


1. Any issues that arise codeclimate should also be resolved.

1. Once changes are made, they should be tested on personal systems or the [integration server](https://github.com/INTO-CPS-Association/DTaaS/wiki/DTaaS-Integration-Server) .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line length

@codeclimate
Copy link

codeclimate bot commented Sep 28, 2023

Code Climate has analyzed commit ba31a95 and detected 654 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 654

View more on Code Climate.

prasadtalasila added a commit that referenced this pull request Sep 29, 2023
  - Adds developer documentation
  - Updates user documentation
  - Uses mermaid to integrate UML diagrams
     into the documentation.
  - Uses madge npm package to generate
    dependency graphs for source code.
  - Corrects the markdown linter configuration to
     catch the warnings in markdown files.
@prasadtalasila
Copy link
Contributor

merged via #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants