Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix planner api change sitl #599

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix planner api change sitl #599

merged 2 commits into from
Nov 27, 2024

Conversation

knmcguire
Copy link
Collaborator

This should fix #587.

Ideally I'd like the python bindings to be able to handle optional variables, but this seems robuust and straight forward enough.

Copy link

@whoenig whoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat solution for compatibility.

@knmcguire
Copy link
Collaborator Author

Thanks! I had an CI issue so I'll fix a flake8 issue first. Then I'll merge

@knmcguire knmcguire merged commit b896e6d into main Nov 27, 2024
4 of 5 checks passed
@knmcguire knmcguire deleted the fix-587 branch November 27, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulation - plan_go_to Requires an Extra t Parameter in cffirmware, Causing Compatibility Issues
2 participants