forked from USC-ACTLab/crazyswarm
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature systemtests sim fixed timestamp #411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienthevenoz
commented
Jan 29, 2024
- Created systemtests_sim.yaml workflow file which runs on every push to main
- modified test_flights.py to accept the --sim CLI argument which runs sim backend
- Added an "avg temporal offset" value in the PDF to indicate how much desired and real graphs are offset (I tried to find a good value but there is always some randomness)
- Created the "figure8_ideal_traj,csv" which includes takeoff and landing to compare desired and real trajectory better. This file is currently in systemtests folder (is that bad placement ?)
…-sim-fixed-timestamp' into feature-systemtests-sim-fixed-timestamp
whoenig
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few small & quick requests.
whoenig
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.