Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecutiveMember model #87

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

nishant-nayak
Copy link
Member

@nishant-nayak nishant-nayak commented Jan 6, 2024

Description

Adds the Executive Member model. Also includes small changes like:

  • Scope the GENDERS list to the User model.
  • Update the max length for phone number to 15 and add validator/pre-save sanitization of phone number.
  • Copy the SIG model definition from Migrating pages #68 . Required for Executive Member dependency. SIG Pages will still be tracked in Migrating pages #68 .
  • Small style fixes on login and index pages, mainly for better readability.
  • Run pre commit hooks on all relevant files

Fixes #45

Dependencies

N/A

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Tested applying migrations onto existing changes on main. Didn't break any data.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

render bot commented Jan 6, 2024

@nishant-nayak nishant-nayak self-assigned this Jan 6, 2024
@nishant-nayak nishant-nayak force-pushed the add_exec_member_models branch from 90103f1 to c518b9e Compare January 6, 2024 18:11
@nishant-nayak nishant-nayak marked this pull request as ready for review January 8, 2024 16:04
corpus/accounts/models.py Show resolved Hide resolved
corpus/accounts/models.py Show resolved Hide resolved
corpus/accounts/validators.py Show resolved Hide resolved
corpus/accounts/views.py Outdated Show resolved Hide resolved
corpus/accounts/views.py Show resolved Hide resolved
corpus/start_dev.sh Outdated Show resolved Hide resolved
@anirudhprabhakaran3 anirudhprabhakaran3 merged commit 5157270 into main Jan 8, 2024
1 check passed
@anirudhprabhakaran3 anirudhprabhakaran3 deleted the add_exec_member_models branch January 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExecutiveMember Model to Accounts
2 participants