Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup JS toolchain for Tailwind and DaisyUI #69

Merged
merged 11 commits into from
Jan 12, 2024

Conversation

anirudhprabhakaran3
Copy link
Member

Description

Setup JS toolchain for Tailwind and DaisyUI.

Fixes # (issue)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

render bot commented Dec 25, 2023

Copy link

livecycle bot commented Dec 25, 2023

ieee-nitk

Your Livecycle playground is ready 🎉.

🔃 _Updating from 9430415 ➡️ 3fceac7 (view log)

Invite team members and start collaborating 💪

Members already invited
  • Nishant Nayak
  • Anirudh Prabhakaran

Click here to invite the rest of your team.

@nishant-nayak
Copy link
Member

Is this something we want to add to dev environments? I definitely see the benefit in adding this toolchain for production releases, but unless there's a way to "hot reload" the Tailwind CSS definitions each time a change is made to frontend code I don't think we should add this to the development toolchain.

@anirudhprabhakaran3
Copy link
Member Author

anirudhprabhakaran3 commented Dec 26, 2023

Aah yes, there is. In the README instructions given, instead of using --minify we just have to use --watch and it will automatically reload everything.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the README, I think the change itself works as expected. Nice addition!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nishant-nayak nishant-nayak merged commit d7828a7 into main Jan 12, 2024
1 of 2 checks passed
@nishant-nayak nishant-nayak deleted the tailwind_js_toolchain branch January 12, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants