-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup JS toolchain for Tailwind and DaisyUI #69
Conversation
Your Render PR Server URL is https://corpus-dev-pr-69.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cm4nc0ud3nmc73chhr50. |
ieee-nitkYour Livecycle playground is ready 🎉.🔃 _Updating from 9430415 ➡️ 3fceac7 (view log) Invite team members and start collaborating 💪 Members already invited
Click here to invite the rest of your team. |
Is this something we want to add to dev environments? I definitely see the benefit in adding this toolchain for production releases, but unless there's a way to "hot reload" the Tailwind CSS definitions each time a change is made to frontend code I don't think we should add this to the development toolchain. |
Aah yes, there is. In the README instructions given, instead of using |
15dffb9
to
38e8fdd
Compare
9430415
to
e391f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the README, I think the change itself works as expected. Nice addition!
Signed-off-by: Nishant Nayak <[email protected]>
089a3f6
to
3fceac7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Setup JS toolchain for Tailwind and DaisyUI.
Fixes # (issue)
Dependencies
List any dependencies that are required for this change.
Type of Change
What types of changes does your code introduce?
Put an
x
in the boxes that applyHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.