Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating pages #68

Merged
merged 48 commits into from
Jan 21, 2024
Merged

Migrating pages #68

merged 48 commits into from
Jan 21, 2024

Conversation

imApoorva36
Copy link
Contributor

Description

Made SIG Pages

Fixes # (issue)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

imApoorva36 and others added 24 commits December 18, 2023 00:44
@imApoorva36
Added Model for SIGs
849dbc4
@imApoorva36
Added model for SIGs
ed10b9d
@imApoorva36
Modified SIG Model and configured django-admin for it and made basic …
990b1bc 
…sig.html
@imApoorva36
Added changes and modifies sig.html
959b9ac
@imApoorva36
Modified minor changes and styling changed
b01dcf1
@imApoorva36
Merge branch 'IEEE-NITK:main' into main
ef6e3df
@imApoorva36
Merge branch 'main' into migrating-pages
55d9af3
@imApoorva36
Added hrefs for SIGs
1bb8906
@imApoorva36
Merge branch 'migrating-pages' of https://github.com/imApoorva36/corpus…
4f73975 
… into migrating-pages
@imApoorva36
Modified minor changes and styling changed and urls modified to avoid…
d430d7e 
… breaking
@imApoorva36
removed learn more button
e91275c
@imApoorva36
Merge branch 'IEEE-NITK:main' into migrating-pages
85d6e92
@imApoorva36 @anirudhprabhakaran3
Added Model for SIGs
2757559
@imApoorva36 @anirudhprabhakaran3
Modified SIG Model and configured django-admin for it and made basic …
424ef51 
…sig.html
@imApoorva36 @anirudhprabhakaran3
Added changes and modifies sig.html
1daf5d8
@imApoorva36 @anirudhprabhakaran3
Modified minor changes and styling changed
927c654
@imApoorva36 @anirudhprabhakaran3
Added hrefs for SIGs
b643e34
@imApoorva36 @anirudhprabhakaran3
Modified minor changes and styling changed and urls modified to avoid…
686b45b 
… breaking
@imApoorva36 @anirudhprabhakaran3
removed learn more button
9df99cf
@anirudhprabhakaran3
PR cleanup
aacfb66
@imApoorva36
Merge branch 'main' into migrating-pages
031fa8c
@imApoorva36
Merge branch 'migrating-pages' of https://github.com/imApoorva36/corpus…
51786fd 
… into migrating-pages
@imApoorva36
Merge branch 'IEEE-NITK:main' into migrating-pages
d5247c1
@imApoorva36
Final Set of All Changes for Sig pages with all necessary additions a…
36dabc3 
…nd code fixes
anirudhprabhakaran3
anirudhprabhakaran3 reviewed Dec 22, 2023
View reviewed changes
corpus/config/migrations/0001_initial.py Outdated Show resolved Hide resolved
corpus/config/models.py Outdated Show resolved Hide resolved
corpus/config/models.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
@nishant-nayak nishant-nayak linked an issue Jan 8, 2024 that may be closed by this pull request
Update Navbar to be similar to old Navbar #75
Closed
Vignaraj-pai
Vignaraj-pai reviewed Jan 13, 2024
View reviewed changes
corpus/config_db.json Outdated Show resolved Hide resolved
Vignaraj-pai
Vignaraj-pai reviewed Jan 13, 2024
View reviewed changes
corpus/config_db.json Outdated Show resolved Hide resolved
nishant-nayak
nishant-nayak requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few small changes. Will test locally and ensure everything is working fine, and I'll drop some more comments if anything needs updating.

corpus/config/migrations/0004_sig_society_sigs.py Outdated Show resolved Hide resolved
corpus/templates/pages/index.html Outdated Show resolved Hide resolved
corpus/templates/pages/index.html Outdated Show resolved Hide resolved
corpus/templates/pages/index.html Outdated Show resolved Hide resolved
nishant-nayak
nishant-nayak requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got to review the UI and suggest UI related changes. I hope this is the last set of reviews for this PR. Thanks for continuing work on this!

corpus/templates/base.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
@imApoorva36
Copy link
Contributor Author

Finally got to review the UI and suggest UI related changes. I hope this is the last set of reviews for this PR. Thanks for continuing work on this!

I've reverted with all the suggested changes, and really Sorry for the minor issues everytime,
Next time when I commit code, I will follow the code workflow with more attention

nishant-nayak
nishant-nayak requested changes Jan 19, 2024
View reviewed changes
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments. Try switching themes and switching viewport sizes while testing.

corpus/templates/components/navbar_small.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
@imApoorva36
Copy link
Contributor Author

Added a few more comments. Try switching themes and switching viewport sizes while testing.

I have reverted with these changes in a new commit, forgot to reply the other day after the commit...

Please do look into it when you're available, and I hope this time I've looked over all edge cases too...

nishant-nayak
nishant-nayak requested changes Jan 21, 2024
View reviewed changes
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added final changes, will commit and merge.

corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
@nishant-nayak nishant-nayak self-requested a review January 21, 2024 17:05
nishant-nayak
nishant-nayak approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for making all the requested changes and working on this PR till the end.

@nishant-nayak nishant-nayak merged commit fc68385 into IEEE-NITK:main Jan 21, 2024
1 of 2 checks passed
@imApoorva36 imApoorva36 deleted the migrating-pages branch January 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vignaraj-pai Vignaraj-pai Vignaraj-pai left review comments

@nishant-nayak nishant-nayak nishant-nayak approved these changes

@anirudhprabhakaran3 anirudhprabhakaran3 Awaiting requested review from anirudhprabhakaran3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Navbar to be similar to old Navbar SIG Pages
4 participants
@imApoorva36 @nishant-nayak @anirudhprabhakaran3 @Vignaraj-pai