Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Model for SIGs #60

Closed
wants to merge 22 commits into from
Closed

Conversation

imApoorva36
Copy link
Contributor

@imApoorva36 imApoorva36 commented Dec 17, 2023

Description

Added model for SIGs

Fixes # (issue)

Dependencies

None new

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

corpus/config/models.py Outdated Show resolved Hide resolved
corpus/config/models.py Outdated Show resolved Hide resolved
@anirudhprabhakaran3
Copy link
Member

Move the model to the pages app.

@nishant-nayak
Copy link
Member

For making any DB related changes, I would highly recommend you check out the ER Diagrams in the wiki. I've documented the fields required, the type of the field and any DB constraints that we should apply.

For this case, the SIG model should go in the config app, alongside the Society model.

@anirudhprabhakaran3
Copy link
Member

Aah yes, my bad. I didn't check the ER diagram before commenting that 😓

Copy link
Member

@anirudhprabhakaran3 anirudhprabhakaran3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all the migration files, and create one single migration file.

corpus/config/admin.py Outdated Show resolved Hide resolved
corpus/config/models.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/pages/urls.py Outdated Show resolved Hide resolved
corpus/pages/views.py Outdated Show resolved Hide resolved
corpus/templates/pages/sig.html Outdated Show resolved Hide resolved
@anirudhprabhakaran3
Copy link
Member

Bruh wait, we need to figure out how to restore those migrations you've deleted.

@imApoorva36 imApoorva36 deleted the migrating-pages branch December 21, 2023 20:06
@imApoorva36 imApoorva36 restored the migrating-pages branch December 21, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants