Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace psycopg2 with the binary version #40

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

anirudhprabhakaran3
Copy link
Member

Description

Previously, we had the normal Postgres plugin for our project, which was built from scratch on every download. This replaces it with the prebuilt binary, so we do not have to keep building on every time environments are created.

Fixes # (issue)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

render bot commented Nov 6, 2023

Copy link

livecycle bot commented Nov 6, 2023

ieee-nitk

Your Livecycle playground is ready 🎉.

Playground version up to date (4d6d5a0)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

  • Nishant Nayak

invite

Members already invited
  • Anirudh Prabhakaran

Click here to invite the rest of your team.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nishant-nayak nishant-nayak merged commit 6c019fb into main Nov 9, 2023
2 checks passed
@nishant-nayak nishant-nayak deleted the replace_postgres_binary branch November 9, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants