Migrated blogs from old site to new django app (Envision project) #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukitya-1811
requested changes
Aug 19, 2024
corpus/accounts/urls.py
Outdated
| @@ -17,7 +17,7 @@ | |||
| path("reset/done/", PasswordResetDoneView.as_view(), name="password_reset_done"), | |||
| path( | |||
| "reset/confirm/<uidb64>/<token>/", | |||
| PasswordResetConfirmView.as_view(), | |||
| PasswordResetConfirmView.as_view(), | |||
There was a problem hiding this comment.
Unnecessary white space. Did you use pre-commit hooks?
corpus/blog/models.py
Outdated
| author=models.ForeignKey(ExecutiveMember,on_delete=models.CASCADE) | ||
| slug = models.SlugField(max_length=200,null=True) | ||
| description = models.CharField(max_length=400) | ||
| author_github = models.CharField(max_length=70,blank=True) |
There was a problem hiding this comment.
Can we not just fetch github from the executive member model? Any reasons for adding an extra field here?
yukitya-1811
reviewed
Sep 6, 2024
| author = models.ForeignKey(ExecutiveMember, on_delete=models.CASCADE) | ||
| slug = models.SlugField(max_length=200, null=True) | ||
| description = models.CharField(max_length=400) | ||
| author_github = models.CharField(max_length=70, blank=True) |
There was a problem hiding this comment.
Can we not use a URL field instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of envision project, I migrated all the blogs from the old jekyll site to a new django app.
Fixes # (issue)
Dependencies
markdown v3.6
Type of Change
What types of changes does your code introduce?
Put an
xin the boxes that applyHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.