-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel - Persistent Language Hint for non-primary language #1324
Merged
jonpas
merged 5 commits into
IDI-Systems:master
from
bagigi-arma:feature/babel-persistent-hint
Jul 3, 2024
Merged
Babel - Persistent Language Hint for non-primary language #1324
jonpas
merged 5 commits into
IDI-Systems:master
from
bagigi-arma:feature/babel-persistent-hint
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrschick
changed the title
Babel - Persistent Language Hint for
Babel - Persistent Language Hint
Apr 11, 2024
jonpas
requested changes
Jul 2, 2024
jonpas
changed the title
Babel - Persistent Language Hint
Babel - Persistent Language Hint for non-primary language
Jul 2, 2024
Mike-MF
reviewed
Jul 2, 2024
Mike-MF
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, works. Just needs other review addressing.
Co-Authored-By: Mike-MF <[email protected]>
Co-authored-by: jonpas <[email protected]>
jonpas
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting varname change requires more changes.
Co-Authored-By: jonpas <[email protected]>
jonpas
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ACRE2 UI
that allows for a persistent language hint (it doesn't fade out) whenever a language other than the "main language" (the first assigned) is selected.