Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat SOG - Improve Racks and Attenuation configs #1253

Merged
merged 13 commits into from
Sep 27, 2023

Conversation

veteran29
Copy link
Contributor

When merged this pull request will:

  • title

@jonpas
Copy link
Member

jonpas commented Sep 6, 2023

@veteran29 I merged this and and made some changes to conform to how ACE3 is doing this. Let me know when this is ready.

@veteran29 veteran29 marked this pull request as ready for review September 6, 2023 12:07
@veteran29
Copy link
Contributor Author

veteran29 commented Sep 6, 2023

If you're fine with the vehicles config being in a subcomponent it's good to go.

It could probably use M41, T-54, PT76 configs for attenuation but I do not have time.

@veteran29
Copy link
Contributor Author

@jonpas
Copy link
Member

jonpas commented Sep 6, 2023

If you're fine with the vehicles config being in a subcomponent it's good to go.

It could probably use M41, T-54, PT76 configs for attenuation but I do not have time.

What's the reason it's in a subconfig instead of just normal config?

Not sure about this: #1253 (files)

vn_car_attenuation is the same as CarAttenuation. vn_tank_attenuation is only slightly different from TankAttenuation. Just use ACRE's existing attenuation classes? If we want specific, then that one being in the compat addon is fine.

@veteran29
Copy link
Contributor Author

veteran29 commented Sep 6, 2023

What's the reason it's in a subconfig instead of just normal config?

No good reason since skipWhenMissingDependencies.

just use ACRE's existing attenuation classes?

I've seen you have dedicated classes for CUP and RHS so have done it the same way:
https://github.com/IDI-Systems/acre2/blob/master/addons/sys_attenuate/CfgSoundEffects.hpp#L55-L66

@jonpas
Copy link
Member

jonpas commented Sep 6, 2023

No good reason since skipWhenMissingDependencies.

Let's put it into main config then.

I've seen you have dedicated classes for CUP and RHS so have done it the same way: master/addons/sys_attenuate/CfgSoundEffects.hpp#L55-L66

Ah, I see. That is from before ACRE2 was even on GitHub. Use the default ones if they fit.

@jonpas
Copy link
Member

jonpas commented Sep 7, 2023

You weren't even using the new attenuation types anywhere.

I merged the subconfig up now. Let me know if this is all.

@jonpas jonpas merged commit c3f289a into IDI-Systems:master Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants