-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat SOG - Improve Racks and Attenuation configs #1253
Conversation
@veteran29 I merged this and and made some changes to conform to how ACE3 is doing this. Let me know when this is ready. |
If you're fine with the vehicles config being in a subcomponent it's good to go. It could probably use M41, T-54, PT76 configs for attenuation but I do not have time. |
What's the reason it's in a subconfig instead of just normal config?
|
No good reason since
I've seen you have dedicated classes for CUP and RHS so have done it the same way: |
Let's put it into main config then.
Ah, I see. That is from before ACRE2 was even on GitHub. Use the default ones if they fit. |
You weren't even using the new attenuation types anywhere. I merged the subconfig up now. Let me know if this is all. |
When merged this pull request will: