Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions - Add Tracy support #1215

Open
wants to merge 17 commits into
base: mumble-plugin
Choose a base branch
from

Conversation

Krzmbrzl
Copy link

@Krzmbrzl Krzmbrzl commented Jul 23, 2022

When merged this pull request will:

  • Add Tracy support in order to be able to investigate the performance issues encountered in the Mumble plugin. Note that Tracy needs to be activated via -DUSE_TRACY=ON when calling cmake
  • Fix a small issue in the Mumble plugin where the returned config path would be inaccessible (due to lying in programs directory)
  • Add CMake option to enable tracing (OFF by default)

@jonpas jonpas changed the title Add Tracy support Extensions - Add Tracy support Jul 23, 2022
@jonpas jonpas added this to the 2.11.0 milestone Jul 23, 2022
@Krzmbrzl
Copy link
Author

@jonpas I think this is now ready for review/merging.
Had I known in advance that I would keep tinkering with this for so long, I would have marked the PR as draft 👀

@jonpas
Copy link
Member

jonpas commented Apr 13, 2023

Self-note: Need to add that to docs and CI, as it's a new extension module.

@jonpas
Copy link
Member

jonpas commented Apr 14, 2023

needs to be activated via -DUSE_TRACY=ON when calling cmake

I don't think that's correct, did you mean -DENABLE_TRACING=ON?

Also can you submodule Tracy on a specific tag instead of a hard-to-find-version commit?


As for CI, I don't think we need to add ACRE2\ACRE2Profiling in

msbuild ACRE.sln /m '/t:ACRE2Arma\acre;ACRE2Arma\arma2ts;ACRE2\ACRE2Steam;ACRE2\ACRE2TS' /p:Configuration=RelWithDebInfo
as it should get automatically pulled in by ACRE2Core like ACRE2Core itself gets pulled into other modules.

I do want to add profiling options to the docs though, if/when Mumble ever gets merged - or maybe cherry-picked out into the main branch at least.

@@ -0,0 +1,3 @@
[submodule "extensions/src/ACRE2Profiling/tracy"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of submodules maybe just use cmake fetch

include(FetchContent)
FetchContent_Declare(
    tracy	
    GIT_REPOSITORY https://github.com/wolfpld/tracy
    GIT_TAG v0.9.1
)
FetchContent_MakeAvailable(tracy)

@jonpas jonpas modified the milestones: 2.11.0, Backlog May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants