Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - Improve Muting and Fix Spectating Gods #1104

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Core - Improve Muting and Fix Spectating Gods #1104

wants to merge 2 commits into from

Conversation

jokoho48
Copy link
Contributor

@jokoho48 jokoho48 commented May 17, 2021 •
edited
Loading

When merged this pull request will:

  • Improve fnc_muting.sqf
  • Fix GodMode not working for Spectating Gods

This PR still needs testing but I wanted to open it to track Progress myself

@jokoho48 jokoho48 marked this pull request as draft May 17, 2021 10:20
@jonpas jonpas changed the title Sys_core - Improve and Fix fnc_muting.sqf Core - Improve Muting May 17, 2021
@jonpas jonpas changed the title Core - Improve Muting Core - Improve Muting and Fix Spectating Gods May 17, 2021
@PabstMirror
Copy link
Collaborator

minor: you can cleanup muting.sqf lines 21/22 as those vars aren't used anywhere else

GVAR(oldSpectators) = [];
GVAR(lastSpectate) = false;

@jokoho48
Cleanup unused Variables
34ea684 
Use Pabst Idea for ACRE_IS_SPECTATOR optimisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug fix enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jokoho48 @PabstMirror @jonpas