Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuwait Theme: Module Details Header #2546

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FaithDaka
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

plh_module_details_header created and styled. Corresponding debug sheet: Link

Author Notes

plh_module_details_header component with the following parameter_list:

  • module_image_asset: The image attached to the module.
  • background_image: For the header background illustration
  • The value column holds the module title

Git Issues

Closes #2535

Screenshots

Design LTR Style RTL Style

@FaithDaka FaithDaka linked an issue Nov 22, 2024 that may be closed by this pull request
4 tasks
@FaithDaka FaithDaka self-assigned this Nov 22, 2024
@FaithDaka FaithDaka added the feature Work on app features/modules label Nov 22, 2024
@FaithDaka FaithDaka added this to the ParentApp Kids KW Dec 2024 milestone Nov 22, 2024
@FaithDaka
Copy link
Collaborator Author

@jfmcquade We had discussed the need to remove app level margins such that they are defined within templates/components. I can do this by setting ion-content values to 0px in the overrides file, though I imagine that will change the look of a lot of the templates/components.

@chrismclarke
Copy link
Member

chrismclarke commented Nov 22, 2024

@jfmcquade We had discussed the need to remove app level margins such that they are defined within templates/components. I can do this by setting ion-content values to 0px in the overrides file, though I imagine that will change the look of a lot of the templates/components.

Yeah ideally we want an app config variable for content_padding or similar that can be set to the default 16px used for most deployments, but then overridable either as a skin or on a per-template level following #2351.

That way an author can just specify in the parameter app_config.content_padding: 0px on the specific template parameter_list column that should remove all padding (or make the default 0). This would then be bound to the <ion-content> element used in the template.page.html (so only top-level template, not nested)

@jfmcquade - is this something you might be able to take on or do you want me to quickly raise a PR to support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Kuwait Theme - Module Details Header
2 participants