fix: gdrive watch mulitple #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmcquade
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Looks good. I can confirm that running the sync --content-watch workflow means that changes made to sheets in each of the folders of the debug_gdrive_multiple deployment trigger an update.
We should now be able to remove that deployment from the repo – that could be included in this PR, or otherwise in a follow-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Following #2091, fix for issue where
sync --content-watchworkflow would break for deployments with multiplesheets_folder_idsspecifiedDev Notes
There will be some duplicate logging of 'watching drive changes...' for each folder looped over in watch scripts. While we could just move the console log to the workflow itself, I think probably good to retain as a reminder that in the future we could probably optimise better (find a way to use one watcher across multiple folders)
I have tested to check that even with multiple watchers the file change script is only triggered once (screenshot below)
Review Notes
Should use
debug_gdrive_multipledeployment and--content-watchsync flag. Making changes to sheets within folders trigger reloadFolder links:
https://drive.google.com/drive/folders/15pDlhePVpTt0XeVsqBrWYToDCK5j-T9F
https://drive.google.com/drive/folders/1kaOxdi3OSNylOmS3YTzLwFnGgTZX9DrM
Git Issues
Closes #
Screenshots/Videos
Example triggered change from multiple folder watch
