Merge pull request #3 from ICube-Robotics/dependabot/github_actions/a… #14

Sign in to view logs

GitHub Actions / Test Results failed Oct 17, 2023 in 0s

20 fail, 3 skipped, 14 pass in 0s

37 tests ±0 14 ✔️ ±0 0s ⏱️ ±0s
15 suites ±0   3 💤 ±0
15 files ±0 20 ❌ ±0

Results for commit 4cfdf6d. ± Comparison against earlier commit e2faabf.

Annotations

Check warning on line 0 in dynamixel_hardware.lint_cmake

github-actions / Test Results

whitespace/mismatch (CMakeLists.txt:37) (dynamixel_hardware.lint_cmake) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/lint_cmake.xunit.xml

Raw output


            Mismatching spaces inside () after command

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

build/include_order [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:25) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Found C++ system header after other header. Should be: dynamixel_hardware.h, c system, c++ system, other.

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

build/include_order [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:26) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Found C++ system header after other header. Should be: dynamixel_hardware.h, c system, c++ system, other.

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

build/include_what_you_use [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:98) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Add #include <string> for string

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:119) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Lines should be <= 100 characters long

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:250) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Lines should be <= 100 characters long

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

whitespace/end_of_line [4] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:301) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Line ends in whitespace.  Consider deleting these extra spaces.

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:307) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Lines should be <= 100 characters long

Check warning on line 0 in dynamixel_hardware.cpplint

github-actions / Test Results

whitespace/end_of_line [4] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:325) (dynamixel_hardware.cpplint) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/cpplint.xunit.xml

Raw output


            Line ends in whitespace.  Consider deleting these extra spaces.

Check warning on line 0 in dynamixel_hardware.uncrustify

github-actions / Test Results

include/dynamixel_hardware/dynamixel_hardware.hpp (dynamixel_hardware.uncrustify) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/uncrustify.xunit.xml

Raw output


            Diff with 9 lines
--- include/dynamixel_hardware/dynamixel_hardware.hpp
+++ include/dynamixel_hardware/dynamixel_hardware.hpp.uncrustify
@@ -49 +49,2 @@
-enum class ControlMode {
+enum class ControlMode
+{
@@ -61 +62 @@
-: public hardware_interface::SystemInterface
+  : public hardware_interface::SystemInterface

Check warning on line 0 in dynamixel_hardware.uncrustify

github-actions / Test Results

src/dynamixel_hardware.cpp (dynamixel_hardware.uncrustify) failed

build/dynamixel_hardware/test_results/dynamixel_hardware/uncrustify.xunit.xml

Raw output


            Diff with 133 lines
--- src/dynamixel_hardware.cpp
+++ src/dynamixel_hardware.cpp.uncrustify
@@ -54,2 +54 @@
-  if (hardware_interface::SystemInterface::on_init(info) != CallbackReturn::SUCCESS)
-  {
+  if (hardware_interface::SystemInterface::on_init(info) != CallbackReturn::SUCCESS) {
@@ -64 +63,2 @@
-      mechanical_reduction_map_.insert(std::pair<std::string, double>(
+      mechanical_reduction_map_.insert(
+        std::pair<std::string, double>(
@@ -83 +83,2 @@
-    info_.hardware_parameters.at("use_dummy") == "true") {
+    info_.hardware_parameters.at("use_dummy") == "true")
+  {
@@ -119 +120,3 @@
-        RCLCPP_INFO(rclcpp::get_logger(kDynamixelHardware), "%s set to %d for joint %d", paramName, value, i);
+        RCLCPP_INFO(
+          rclcpp::get_logger(
+            kDynamixelHardware), "%s set to %d for joint %d", paramName, value, i);
@@ -171,2 +174,3 @@
-        control_items_[kGoalPositionItem]->address, control_items_[kGoalPositionItem]->data_length,
-        &log)) {
+      control_items_[kGoalPositionItem]->address, control_items_[kGoalPositionItem]->data_length,
+      &log))
+  {
@@ -178,2 +182,3 @@
-        control_items_[kGoalVelocityItem]->address, control_items_[kGoalVelocityItem]->data_length,
-        &log)) {
+      control_items_[kGoalVelocityItem]->address, control_items_[kGoalVelocityItem]->data_length,
+      &log))
+  {
@@ -187,2 +192,2 @@
-                         control_items_[kPresentVelocityItem]->data_length +
-                         control_items_[kPresentCurrentItem]->data_length + 2;
+    control_items_[kPresentVelocityItem]->data_length +
+    control_items_[kPresentCurrentItem]->data_length + 2;
@@ -202,6 +207,9 @@
-    state_interfaces.emplace_back(hardware_interface::StateInterface(
-      info_.joints[i].name, hardware_interface::HW_IF_POSITION, &joints_[i].state.position));
-    state_interfaces.emplace_back(hardware_interface::StateInterface(
-      info_.joints[i].name, hardware_interface::HW_IF_VELOCITY, &joints_[i].state.velocity));
-    state_interfaces.emplace_back(hardware_interface::StateInterface(
-      info_.joints[i].name, hardware_interface::HW_IF_EFFORT, &joints_[i].state.effort));
+    state_interfaces.emplace_back(
+      hardware_interface::StateInterface(
+        info_.joints[i].name, hardware_interface::HW_IF_POSITION, &joints_[i].state.position));
+    state_interfaces.emplace_back(
+      hardware_interface::StateInterface(
+        info_.joints[i].name, hardware_interface::HW_IF_VELOCITY, &joints_[i].state.velocity));
+    state_interfaces.emplace_back(
+      hardware_interface::StateInterface(
+        info_.joints[i].name, hardware_interface::HW_IF_EFFORT, &joints_[i].state.effort));
@@ -218,4 +226,6 @@
-    command_interfaces.emplace_back(hardware_interface::CommandInterface(
-      info_.joints[i].name, hardware_interface::HW_IF_POSITION, &joints_[i].command.position));
-    command_interfaces.emplace_back(hardware_interface::CommandInterface(
-      info_.joints[i].name, hardware_interface::HW_IF_VELOCITY, &joints_[i].command.velocity));
+    command_interfaces.emplace_back(
+      hardware_interface::CommandInterface(
+        info_.joints[i].name, hardware_interface::HW_IF_POSITION, &joints_[i].command.position));
+    command_interfaces.emplace_back(
+      hardware_interface::CommandInterface(
+        info_.joints[i].name, hardware_interface::HW_IF_VELOCITY, &joints_[i].command.velocity));
@@ -250 +260,3 @@
-return_type DynamixelHardware::read(const rclcpp::Time & /* time */, const rclcpp::Duration & /* period */)
+return_type DynamixelHardware::read(
+  const rclcpp::Time & /* time */,
+  const rclcpp::Duration & /* period */)
@@ -265 +277,2 @@
-        kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(), &log)) {
+      kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(), &log))
+  {
@@ -270,3 +283,4 @@
-        kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
-        control_items_[kPresentCurrentItem]->address,
-        control_items_[kPresentCurrentItem]->data_length, currents.data(), &log)) {
+      kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
+      control_items_[kPresentCurrentItem]->address,
+      control_items_[kPresentCurrentItem]->data_length, currents.data(), &log))
+  {
@@ -277,3 +291,4 @@
-        kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
-        control_items_[kPresentVelocityItem]->address,
-        control_items_[kPresentVelocityItem]->data_length, velocities.data(), &log)) {
+      kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
+      control_items_[kPresentVelocityItem]->address,
+      control_items_[kPresentVelocityItem]->data_length, velocities.data(), &log))
+  {
@@ -284,3 +299,4 @@
-        kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
-        control_items_[kPresentPositionItem]->address,
-        control_items_[kPresentPositionItem]->data_length, positions.data(), &log)) {
+      kPresentPositionVelocityCurrentIndex, ids.data(), ids.size(),
+      control_items_[kPresentPositionItem]->address,
+      control_items_[kPresentPositionItem]->data_length, positions.data(), &log))
+  {
@@ -297 +313 @@
-    if(mechanical_reduction_map_.find(info_.joints[i].name) != mechanical_reduction_map_.end()){
+    if (mechanical_reduction_map_.find(info_.joints[i].name) != mechanical_reduction_map_.end()) {
@@ -301 +317 @@
-    } 
+    }
@@ -307 +323,3 @@
-return_type DynamixelHardware::write(const rclcpp::Time & /* time */, const rclcpp::Duration & /* period */)
+return_type DynamixelHardware::write(
+  const rclcpp::Time & /* time */,
+  const rclcpp::Duration & /* period */)
@@ -321 +339 @@
-    if(mechanical_reduction_map_.find(info_.joints[i].name) != mechanical_reduction_map_.end()){
+    if (mechanical_reduction_map_.find(info_.joints[i].name) != mechanical_reduction_map_.end()) {
@@ -325 +343 @@
-    } 
+    }
@@ -332 +350,2 @@
-        joints_.cbegin(), joints_.cend(), [](auto j) { return j.command.velocity != 0.0; })) {
+      joints_.cbegin(), joints_.cend(), [](auto j) {return j.command.velocity != 0.0;}))
+  {
@@ -340 +359,2 @@
-          kGoalVelocityIndex, ids.data(), ids.size(), commands.data(), 1, &log)) {
+        kGoalVelocityIndex, ids.data(), ids.size(), commands.data(), 1, &log))
+    {
@@ -345 +365,2 @@
-               joints_.cbegin(), joints_.cend(), [](auto j) { return j.command.effort != 0.0; })) {
+      joints_.cbegin(), joints_.cend(), [](auto j) {return j.command.effort != 0.0;}))
+  {
@@ -358 +379,2 @@
-        kGoalPositionIndex, ids.data(), ids.size(), commands.data(), 1, &log)) {
+      kGoalPositionIndex, ids.data(), ids.size(), commands.data(), 1, &log))
+  {
@@ -415 +437,2 @@
-    mode == ControlMode::Position && (force_set || control_mode_ != ControlMode::Position)) {
+    mode == ControlMode::Position && (force_set || control_mode_ != ControlMode::Position))
+  {

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

W291 (./scripts/trajectory_node.py:7:14) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            trailing whitespace:
import random

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

E302 (./scripts/trajectory_node.py:9:1) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            expected 2 blank lines, found 1:
class DummyState(Node):

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

E501 (./scripts/trajectory_node.py:13:100) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            line too long (110 > 99 characters):
        self.publisher_ = self.create_publisher(JointTrajectory, '/trajectory_controller/joint_trajectory', 1)

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

E231 (./scripts/trajectory_node.py:20:36) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            missing whitespace after ',':
        msg.joint_names = ['joint1','joint2','joint3']

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

E231 (./scripts/trajectory_node.py:20:45) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            missing whitespace after ',':
        msg.joint_names = ['joint1','joint2','joint3']

Check warning on line 0 in spirits_nodes.flake8

github-actions / Test Results

E501 (./scripts/trajectory_node.py:22:100) (spirits_nodes.flake8) failed

build/spirits_nodes/test_results/spirits_nodes/flake8.xunit.xml

Raw output


            line too long (103 > 99 characters):
        point.positions = [random.random()*1.2-0.6, random.random()*1.6-0.8, 0.01+random.random()*0.07]

Check warning on line 0 in spirits_bringup.flake8

github-actions / Test Results

E114 (./launch/spirits.launch.py:23:6) (spirits_bringup.flake8) failed

build/spirits_bringup/test_results/spirits_bringup/flake8.xunit.xml

Raw output


            indentation is not a multiple of 4 (comment):
     # Get URDF via xacro

Check warning on line 0 in spirits_bringup.flake8

github-actions / Test Results

E117 (./launch/spirits.launch.py:23:6) (spirits_bringup.flake8) failed

build/spirits_bringup/test_results/spirits_bringup/flake8.xunit.xml

Raw output


            over-indented (comment):
     # Get URDF via xacro

Check warning on line 0 in spirits_bringup.flake8

github-actions / Test Results

W293 (./launch/spirits.launch.py:40:1) (spirits_bringup.flake8) failed

build/spirits_bringup/test_results/spirits_bringup/flake8.xunit.xml

Raw output


            blank line contains whitespace:

Check notice on line 0 in .github

github-actions / Test Results

3 skipped tests found

There are 3 skipped tests, see "Raw output" for the full list of skipped tests.

Raw output


            dynamixel_hardware.cppcheck ‑ include/dynamixel_hardware/dynamixel_hardware.hpp
dynamixel_hardware.cppcheck ‑ include/dynamixel_hardware/visiblity_control.h
dynamixel_hardware.cppcheck ‑ src/dynamixel_hardware.cpp

Check notice on line 0 in .github

github-actions / Test Results

37 tests found

There are 37 tests, see "Raw output" for the full list of tests.

Raw output


            dynamixel_hardware.copyright ‑ include/dynamixel_hardware/dynamixel_hardware.hpp
dynamixel_hardware.copyright ‑ include/dynamixel_hardware/visiblity_control.h
dynamixel_hardware.copyright ‑ src/dynamixel_hardware.cpp
dynamixel_hardware.cppcheck ‑ include/dynamixel_hardware/dynamixel_hardware.hpp
dynamixel_hardware.cppcheck ‑ include/dynamixel_hardware/visiblity_control.h
dynamixel_hardware.cppcheck ‑ src/dynamixel_hardware.cpp
dynamixel_hardware.cpplint ‑ /ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/visiblity_control.h
dynamixel_hardware.cpplint ‑ build/include_order [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:25)
dynamixel_hardware.cpplint ‑ build/include_order [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:26)
dynamixel_hardware.cpplint ‑ build/include_what_you_use [4] (/ros/src/spirits/dynamixel_hardware/include/dynamixel_hardware/dynamixel_hardware.hpp:98)
dynamixel_hardware.cpplint ‑ whitespace/end_of_line [4] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:301)
dynamixel_hardware.cpplint ‑ whitespace/end_of_line [4] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:325)
dynamixel_hardware.cpplint ‑ whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:119)
dynamixel_hardware.cpplint ‑ whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:250)
dynamixel_hardware.cpplint ‑ whitespace/line_length [2] (/ros/src/spirits/dynamixel_hardware/src/dynamixel_hardware.cpp:307)
dynamixel_hardware.lint_cmake ‑ whitespace/mismatch (CMakeLists.txt:37)
dynamixel_hardware.uncrustify ‑ include/dynamixel_hardware/dynamixel_hardware.hpp
dynamixel_hardware.uncrustify ‑ include/dynamixel_hardware/visiblity_control.h
dynamixel_hardware.uncrustify ‑ src/dynamixel_hardware.cpp
dynamixel_hardware.xmllint ‑ dynamixel_hardware.xml
dynamixel_hardware.xmllint ‑ package.xml
spirits_bringup.copyright ‑ launch/spirits.launch.py
spirits_bringup.flake8 ‑ E114 (./launch/spirits.launch.py:23:6)
spirits_bringup.flake8 ‑ E117 (./launch/spirits.launch.py:23:6)
spirits_bringup.flake8 ‑ W293 (./launch/spirits.launch.py:40:1)
spirits_bringup.lint_cmake ‑ CMakeLists.txt
spirits_bringup.pep257 ‑ ./launch/spirits.launch.py
spirits_bringup.xmllint ‑ package.xml
spirits_nodes.flake8 ‑ E231 (./scripts/trajectory_node.py:20:36)
spirits_nodes.flake8 ‑ E231 (./scripts/trajectory_node.py:20:45)
spirits_nodes.flake8 ‑ E302 (./scripts/trajectory_node.py:9:1)
spirits_nodes.flake8 ‑ E501 (./scripts/trajectory_node.py:13:100)
spirits_nodes.flake8 ‑ E501 (./scripts/trajectory_node.py:22:100)
spirits_nodes.flake8 ‑ W291 (./scripts/trajectory_node.py:7:14)
spirits_nodes.lint_cmake ‑ CMakeLists.txt
spirits_nodes.pep257 ‑ ./scripts/trajectory_node.py
spirits_nodes.xmllint ‑ package.xml

View more details on GitHub Actions