First batch of fixes for #53 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some experiments I was able to reproduce the non-positive density errors earlier on in the code, right after all particles have their densities calculated. I thus decided to refactor the creation of the error message out of its previous place (localbgcomp.cxx) and move it into an exception that can be easily thrown from various places in the code. Signed-off-by: Rodrigo Tobar <[email protected]>
A bug can occur when an mpi rank imports 0 particles from other mpi domains in localfield.cxx. Particles that have not had their densities calculated are incorrectly skipped resulting in segfaults later on. These changes address this issue.
3d-runRelevant configuration parameters full file:
R_200crit v/s Mass_200crit: R_200mean v/s Mass_200mean: Mass_200crit histogram: Mass_200mean histogram: R_200crit histogram: R_200mean histogram: 6d-runRelevant configuration parameters full file:
R_200crit v/s Mass_200crit: R_200mean v/s Mass_200mean: Mass_200crit histogram: Mass_200mean histogram: R_200crit histogram: R_200mean histogram: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address the problems highlighted in #53, at least for MPI-enabled cases. This PR is only to kick off the CI pipeline and double-check that those runs don't break; otherwise the changes have been tested on a couple of known failing inputs which are working again.