-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parameters.py #1542
Update parameters.py #1542
Conversation
Fix issue #1535
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1542 +/- ##
===========================================
- Coverage 84.36% 84.34% -0.03%
===========================================
Files 163 163
Lines 14034 14035 +1
===========================================
- Hits 11840 11838 -2
- Misses 2194 2197 +3 ☔ View full report in Codecov by Sentry. |
Thanks. Is there a reason for using |
Not sure entirely - but in general byte array has a smaller storage footprint (str depends on encoding) - also to my understanding faster to process. (Don't think that matters there, but maybe for other attributes of the read-in result object). Maybe someone can shed light on that - then I agree, would make more sense to change it in |
the issue originates from data is read from the h5 file, which provides byte strings, but is never decoded (x_names is done correctly and decoded though) a bit odd that this did not surface more often in the past? |
Revert changes.
Decode byte str to str.
Now should be fixed at the point or origin. Please have a look, ping @PaulJonasJost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing 👍🏼
All credits to @C-Peiter for reporting the issue ;-) |
Quick fix for issue #1535
Also underlying cause is that
pypesto.store.read_result
loadsresult.problem.x_scales
as<class 'bytes'>
and error surfaces here during string concatenation. (Maybe return attributes consistently as<class 'str'>
throughout?)